Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_giuh_array_water #34

Merged
merged 2 commits into from
Sep 13, 2024
Merged

fix_giuh_array_water #34

merged 2 commits into from
Sep 13, 2024

Conversation

ajkhattak
Copy link
Collaborator

The PR fixed two bugs related to not accurately computing the leftover water in the GIUH array at the end of simulation, and in reading the giuh ordinates. No Changes to functionality.

Additions

  • None

Removals

  • None

Changes

  • bug fixes

Testing

  1. All existing tests pass

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Reviewers requested with the Reviewers tool ➡️

@ajkhattak ajkhattak added the bug Something isn't working label Sep 13, 2024
Copy link
Contributor

@peterlafollette peterlafollette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked over the changes and these look good, I appreciate that the functionality wasn't changed except for fixing an off by 1 error in the GIUH queue. Merge when you want!

@ajkhattak ajkhattak merged commit 0c15004 into master Sep 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants