handle_invalid_soil_type #31
Conversation
…etc., the model returns input precip as discharge.
Co-authored-by: Austin Raney <[email protected]>
| state->lgar_mass_balance.volend_cm = state->lgar_mass_balance.volstart_cm; | ||
| state->lgar_mass_balance.volAET_cm = 0.0; | ||
| state->lgar_mass_balance.volrech_cm = 0.0; | ||
| state->lgar_mass_balance.volrunoff_cm += state->lgar_bmi_input_params->precipitation_mm_per_h * mm_to_cm; |
There was a problem hiding this comment.
is volrunoff and volQ the same thing? If not, this looks like a mass balance logical error since the precipitation is being accounted for twice.
There was a problem hiding this comment.
currently they are the same, once we merge LGARTO, they will be different
… an upper limit on num_soil_type as the default is already there.
|
@hellkite500 I am going to revisit this |
configs/README.md
Outdated
| @@ -15,7 +15,7 @@ A detailed description of the parameters for model configuration (i.e., initiali | |||
| | forcing_resolution | double (scalar)| - | sec/min/hr | temporal resolution | - | timestep of the forcing data. Recommended value of 3600 seconds. | | |||
| | endtime | double (scalar)| >0 | sec, min, hr, d | simulation duration | - | time at which model simulation ends | | |||
| | layer_soil_type | int (1D array) | - | - | state variable | - | layer soil type (read from the database file soil_params_file) | | |||
| | max_soil_types | int | >1 | - | - | - | maximum number of soil types read from the file soil_params_file (default is set to 15) | | |||
| | max_valid_soil_types | int | >1 | - | - | - | maximum number of valid soil types read from the file soil_params_file (default is set to 12; model not valid for soil_type = waterbody, lava, glacier, etc.) | | |||
There was a problem hiding this comment.
It should be noted that if this value is more than the constant defined here
Line 39 in 5120df4
then an error/exit condition exists. I don't think this the number impacts the implementation details of this PR, but it is a somewhat odd out-of-band validation that is relevant.
There was a problem hiding this comment.
I am not seeing if MAX_NUM_SOIL_TYPES is used anywhere, I am going to push a change to put this as an upper limit.
There was a problem hiding this comment.
I realized that it isn't used in any of the BMI code paths, for sure, but in the src/main.cxx there is this check:
Line 258 in 5120df4
The PR checks if the provided soil type(s) are not valid soil_types for the model such as waterbody, glacier etc. The model BMI Update returns input_precipitation as stream discharge output.
For now, invalid soil types should be appended to the end of the
vG_soil_param.txtfile, and setmax_valid_soil_types(previouslymax_soil_types) to the number of valid soil types in the file. Later, we can make it more fancy.Additions
Removals
Changes
Testing
Checklist