add to inv for pdt 49 #273 #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we have an issue for this please? |
|
When I switch the UPP configuration to generate GFS grib2 files, there is
no issue with dumping the aerosol wavelength.
================================
***@***.*** post_gfs_2023080300$ pwd
/u/wen.meng/ptmp/post_gfs_2023080300
***@***.*** post_gfs_2023080300$ wgrib2 GFSPRS.GrbF09 -match PMTF
8:6766731:d=2023080300:PMTF:1 hybrid level:9 hour fcst:aerosol=Dust
dry:*aerosol_size
=2e-07,<2e-06:*
...
I am using wgrib2 v3.1.3 to dump GEFS grib2 files which generate from UPP.
It seems me that aerosol wavelength information is missing in the file
GFSPRS.GrbF09 at /u/wen.meng/ptmp/post_gefs_2023080300 on Cactus.
==================================
***@***.*** post_gefs_2023080300$ wgrib2 GFSPRS.GrbF09 -match PMTF
8:6766752:d=2023080300:PMTF:1 hybrid level:9 hour fcst:ENS=+1:aerosol=Dust
dry
The difference is that the GFS shows the "aerosol size". This was added a
long time ago because
some grib files had grib messages with the same aerosol but different
sizes. I added the aerosol size
the inventory to the
deterministic grib messages (PDT=48). Now the GEFS is creating aerosols
for the ensemble members
(PDT=49). So aerosol size needs to be added.
…On Tue, Oct 15, 2024 at 11:49 AM Edward Hartnett ***@***.***> wrote:
Can we have an issue for this please?
—
Reply to this email directly, view it on GitHub
<#274 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEIB7ZUP7TD2PCSUKLA622TZ3T6KXAVCNFSM6AAAAABP5CNV22VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJTGY4TINBTGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I mean, reference the issue number in this PR (as I have done). Issues are how we keep track of progress and prepare our release notes. If there is no issue, or the issue is not assigned to the correct version, then it will not be listed in the release notes. |
|
… On Tue, Oct 15, 2024 at 3:20 PM Edward Hartnett ***@***.***> wrote:
I mean, reference the issue number in this PR (as I have done).
Issues are how we keep track of progress and prepare our release notes. If
there is no issue, or the issue is not assigned to the correct version,
then it will not be listed in the release notes.
—
Reply to this email directly, view it on GitHub
<#274 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEIB7ZSFUYQ3S4B2QC5UFMLZ3UXEDAVCNFSM6AAAAABP5CNV22VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJUGI3TIMJVGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
AlysonStahl-NOAA
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inventory for PDT 49 should show aerosol size. Needed to fix Aerosol.c because it was hardwired for PDT=48. (The code is old.) The inventory is controlled by Extname.c Includes test.
Part of #273