Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix shared libs, no CALLABLE_WGRIB2, wgrib2 utility calls wgrib2(..) 234, 213, 212 #248

Merged
merged 10 commits into from
Oct 18, 2024

Conversation

webisu
Copy link
Collaborator

@webisu webisu commented Sep 16, 2024

wgrib2 utility calls wgrib2(..) .. so no need for compiling wgrib2.c
with/without CALLABLE_WGRIB2 which was needed for utility vs lib build

BUILD_SHARED_LIB now works but not for python,
Python required external libraries to be added to libwgrib2.so. Only way to do
that was to build libwgrib2.a and combine with other *.a libraries
BUILD_LIB now makes relocatable code for python support.
The ftn_api library was renamed from libwgrib2_api to libwgrib2_ftn_api
Since the build for fortran codes that call libwgrib2 will be changing, it seemed
the right time to change the name of the library to something more descriptive.

In the future, the build of wgrib2_lib and obj_lib can be combined to reduce build time.

Fixes #234, #213, #248

wgrib2/CMakeLists.txt Outdated Show resolved Hide resolved
@AlysonStahl-NOAA AlysonStahl-NOAA merged commit 25fd33c into develop Oct 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change main() so that it always calls wgrib2 as subroutine
3 participants