Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove png's/LFS #10

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Remove png's/LFS #10

merged 1 commit into from
Jul 19, 2024

Conversation

guillaumevernieres
Copy link
Contributor

What the title says. We currently cannot clone develop or the commit that the gdasapp uses:

jcb-error

Cloning this branch works:

git clone --branch feature/ciao-lfs https://github.com/NOAA-EMC/jcb.git
Cloning into 'jcb'...
remote: Enumerating objects: 659, done.
remote: Counting objects: 100% (21/21), done.
remote: Compressing objects: 100% (21/21), done.
remote: Total 659 (delta 0), reused 1 (delta 0), pack-reused 638
Receiving objects: 100% (659/659), 121.50 KiB | 5.28 MiB/s, done.
Resolving deltas: 100% (286/286), done.

Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve. Thank you @guillaumevernieres for quick action on this.

Copy link

@DavidNew-NOAA DavidNew-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@guillaumevernieres guillaumevernieres merged commit 8269ce4 into develop Jul 19, 2024
6 checks passed
@guillaumevernieres guillaumevernieres deleted the feature/ciao-lfs branch July 19, 2024 21:14
@guillaumevernieres
Copy link
Contributor Author

that was quick! Thanks @RussTreadon-NOAA and @DavidNew-NOAA .

guillaumevernieres pushed a commit to NOAA-EMC/GDASApp that referenced this pull request Jul 22, 2024
g-w PR [#2782](NOAA-EMC/global-workflow#2782)
and jcb PR [#10](NOAA-EMC/jcb#10) document the
need to remove png files from the `jcb` repository. The files were
removed at
[`8269ce4`](NOAA-EMC/jcb@8269ce4).

This PR updates the `sorc/jcb` hash to
[`8269ce4`](NOAA-EMC/jcb@8269ce4).

Resolves #1229
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants