Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create JCB templates for marine B-matrix #36

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Create JCB templates for marine B-matrix #36

wants to merge 4 commits into from
+283 −0

Conversation

DavidNew-NOAA
Copy link
Contributor

@DavidNew-NOAA DavidNew-NOAA commented Oct 23, 2024 •
edited
Loading

This PR is a companion to Global Workflow PR #2992 and GDASApp PR #1346.

It adds JCB templates for the input YAMLS of JEDI applications used in the marine B-matrix task in the Global Workflow.

This was referenced Oct 23, 2024
Open
Open
danholdaway
danholdaway reviewed Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@danholdaway danholdaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It might be good to modify the testing of marine in the main JCB repo to include these algorithms. There's an example of that for the atmosphere.

guillaumevernieres
guillaumevernieres reviewed Oct 24, 2024
View reviewed changes
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2 diffusion yamls are missing the "levels" key. I thought I modified in a previous prit but maybe not. I'll look into it later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaumevernieres guillaumevernieres guillaumevernieres left review comments

@danholdaway danholdaway danholdaway left review comments

@AndrewEichmann-NOAA AndrewEichmann-NOAA Awaiting requested review from AndrewEichmann-NOAA

@CoryMartin-NOAA CoryMartin-NOAA Awaiting requested review from CoryMartin-NOAA

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DavidNew-NOAA @guillaumevernieres @danholdaway