Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Correctly set overwrite option when specified #3021

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

DavidHuber-NOAA
Copy link
Contributor

Description

This specifies a correct option for the overwrite option in setup_expt.py when called with the --overwrite flag. As-is, the EXPDIR and COMROOT directories are not actually deleted when --overwrite is specified.

This also removes an unused module (warnings) and method (to_timedelta) from setup_expt.py.

Type of change

  • Bug fix (fixes something broken)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

Ran setup_expt.py with --overwrite and verified the EXPDIR and COMROOT were actually deleted before repopulating.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added

Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @DavidHuber-NOAA !

@DavidHuber-NOAA DavidHuber-NOAA merged commit d9d30a1 into NOAA-EMC:develop Oct 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants