-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gdas.cd #2978
base: develop
Are you sure you want to change the base?
Update gdas.cd #2978
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
@guillaumevernieres , the hash for |
Co-authored-by: Rahul Mahajan <[email protected]>
9538ba5
Thanks @RussTreadon-NOAA , working on it this morning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections
dc2ae99
@WalterKolczynski-NOAA . This PR is ready for g-w CI ready labels to be applied. I successfully ran C96C48_hybatmaerosnowDA on Hera using 6c30d36. The other DA based g-w CI passed using 4f17f52. DA g-w CI was started on Hercules and Orion yesterday afternoon. I did not log onto either machine before the 10/23 PM began. I'll check results when both machines return to service. I expect C96C48_hybatmaerosnowDA failed. Updating to 6c30d36 will fix the failures. GSI and JEDI based atmospheric DA g-w CI is now running on Cactus. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending successful completion of CI tests.
DA-based g-w CI Install
All jobs in all cycles for each of the above g-w CI stream successfully run to completion on Hera, Hercules, and Orion. As noted in previous comments only C96C48_hybatmDA and C96C48_ufs_hybatmDA successfully run to completion on Cactus. The other two tests, C96C48_hybatmaerosnowDA and C48mx500_3DVarAOWCDA, are marked to be skipped on
@WalterKolczynski-NOAA , do you need anything else from me or reviewers before we can activate label based g-w CI for this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DA based g-w CI has been run on Cactus, Hera, Hercules, and Orion.
- All jobs from all streams pass on Hera, Hercules, and Orion.
- GSI and JEDI-based atmospheric DA pass on Cactus. Aerosol / snow DA and WCDA fail on Cactus. These failures are being tracked via GDASApp issues. These tests are marked to be skipped on WCOSS2.
Approve.
@WalterKolczynski-NOAA do you know when we can start the CI to get this merged? Or can we merge given Russ's testing above? |
Description
Updates to the
gdas.cd
#.@RussTreadon-NOAA will submit a PR in the GDASApp, we'll update the gdas.cd # in this branch after the GDASApp PR is merged.
In the mean time, could somebody review the few simple code changes that are needed to run with the new #?
Type of change
Change characteristics
How has this been tested?
Run subset of g-w CI on Hera, Hercules, Orion, and WCOSS2 (Cactus)
Checklist