Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gdas.cd #2978

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from

Conversation

guillaumevernieres
Copy link
Contributor

@guillaumevernieres guillaumevernieres commented Oct 3, 2024

Description

Updates to the gdas.cd #.
@RussTreadon-NOAA will submit a PR in the GDASApp, we'll update the gdas.cd # in this branch after the GDASApp PR is merged.
In the mean time, could somebody review the few simple code changes that are needed to run with the new #?

  • Depends on GDASApp PR #1310
  • Depends on g-w issue #3012

Type of change

  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? YES

How has this been tested?

Run subset of g-w CI on Hera, Hercules, Orion, and WCOSS2 (Cactus)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • This change is covered by an existing CI test or a new one has been added

CoryMartin-NOAA
CoryMartin-NOAA previously approved these changes Oct 3, 2024
aerorahul
aerorahul previously approved these changes Oct 4, 2024
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@RussTreadon-NOAA
Copy link
Contributor

@guillaumevernieres , the hash for sorc/gdas.cd can be updated. GDASApp PR #1310 was merged into develop at 9d95c9d.

@guillaumevernieres guillaumevernieres changed the title Feature/update hashes Update gdas.cd Oct 7, 2024
@guillaumevernieres
Copy link
Contributor Author

@guillaumevernieres , the hash for sorc/gdas.cd can be updated. GDASApp PR #1310 was merged into develop at 9d95c9d.

Thanks @RussTreadon-NOAA , working on it this morning.

@guillaumevernieres guillaumevernieres marked this pull request as ready for review October 7, 2024 13:21
CoryMartin-NOAA
CoryMartin-NOAA previously approved these changes Oct 7, 2024
aerorahul
aerorahul previously approved these changes Oct 7, 2024
@aerorahul aerorahul added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion CI-Wcoss2-Ready **CM use only** PR is ready for CI testing on WCOSS labels Oct 7, 2024
@emcbot emcbot added CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS and removed CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Wcoss2-Ready **CM use only** PR is ready for CI testing on WCOSS labels Oct 7, 2024
Copy link
Contributor

@AndrewEichmann-NOAA AndrewEichmann-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections

@RussTreadon-NOAA RussTreadon-NOAA dismissed stale reviews from AndrewEichmann-NOAA, aerorahul, and themself via dc2ae99 October 22, 2024 15:47
@RussTreadon-NOAA
Copy link
Contributor

@WalterKolczynski-NOAA . This PR is ready for g-w CI ready labels to be applied.

I successfully ran C96C48_hybatmaerosnowDA on Hera using 6c30d36. The other DA based g-w CI passed using 4f17f52.

DA g-w CI was started on Hercules and Orion yesterday afternoon. I did not log onto either machine before the 10/23 PM began. I'll check results when both machines return to service. I expect C96C48_hybatmaerosnowDA failed. Updating to 6c30d36 will fix the failures.

GSI and JEDI based atmospheric DA g-w CI is now running on Cactus.

Copy link
Contributor

@WalterKolczynski-NOAA WalterKolczynski-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending successful completion of CI tests.

@WalterKolczynski-NOAA WalterKolczynski-NOAA removed CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed CI-Wcoss2-Failed **Bot use only** CI testing on WCOSS for this PR has failed labels Oct 23, 2024
@RussTreadon-NOAA
Copy link
Contributor

DA-based g-w CI

Install guillaumevernieres:feature/update_hashes at 6c30d36 on Cactus, Hera, Hercules, and Orion. Set up and run g-w CI for the following DA configurations

  • C96C48_hybatmDA
  • C96C48_ufs_hybatmDA
  • C96C48_hybatmaerosnowDA
  • C48mx500_3DVarAOWCDA

All jobs in all cycles for each of the above g-w CI stream successfully run to completion on Hera, Hercules, and Orion.

As noted in previous comments only C96C48_hybatmDA and C96C48_ufs_hybatmDA successfully run to completion on Cactus.

The other two tests, C96C48_hybatmaerosnowDA and C48mx500_3DVarAOWCDA, are marked to be skipped on wcoss2 via the skip_ci_on_hosts list. The following GDASApp issues have been opened to investigate the WCOSS2 failures of these two jobs

@WalterKolczynski-NOAA , do you need anything else from me or reviewers before we can activate label based g-w CI for this PR?

Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DA based g-w CI has been run on Cactus, Hera, Hercules, and Orion.

  • All jobs from all streams pass on Hera, Hercules, and Orion.
  • GSI and JEDI-based atmospheric DA pass on Cactus. Aerosol / snow DA and WCDA fail on Cactus. These failures are being tracked via GDASApp issues. These tests are marked to be skipped on WCOSS2.

Approve.

@CoryMartin-NOAA
Copy link
Contributor

@WalterKolczynski-NOAA do you know when we can start the CI to get this merged? Or can we merge given Russ's testing above?

@WalterKolczynski-NOAA WalterKolczynski-NOAA added the CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera label Oct 24, 2024
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera labels Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.