Add STRM and VPOT at 200mb to SFS #1072
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,176 @@ | |||
| !> @file | |||
There was a problem hiding this comment.
@KarinaAsmar-NOAA @JesseMeng-NOAA Is this new algorithms from George Vandenberghe?
There was a problem hiding this comment.
@WenMeng-NOAA No. This is still using the spectral calculation from CFS. @JesseMeng-NOAA found a way to reduce the runtimes by modifying the level loops.
There was a problem hiding this comment.
This infrastructure of this subroutine does not match that of UPP and UFS MPI code.
| ! | ||
| ! SAVE ALL P LEVELS OF U/V WINDS AT GLOBAL GRID | ||
|
|
||
| ALLOCATE(COL_UWIND(IM,JM)) |
There was a problem hiding this comment.
@KarinaAsmar-NOAA @JesseMeng-NOAA Allocating many variables for the full domain will impact UFS memory usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the CPC-requested streamfunction and velocity potential at 200mb to SFS. It is meant to resolve [Issue #902 ] and update on the runtime issues from the previous PR #951 . Job scripts used for testing are in WCOSS2: /lfs/h2/emc/vpppg/noscrub/karina.asmar/vpot_strm/UPP (submit_run_gfsv16_wcoss2.sh and submit_run_sfs_wcoss2.sh).