adding utils to code coverage #755
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How is this coming? |
|
There's still the matter of the memory problems with utils test, so I've been working to see if I can fix them so we can finally include them in the test coverage. It's been a little tricky. Is there a way to still include the tests in the test coverage without including them in the memory checks? If so, do you think it would be better to do that, then fix the memory issues in another PR? |
|
Yes, separate the code coverage from the memory issue. Turn off memory checking for utils, but leave on code coverage. Let me know if you need help. On another repo I found it useful to have separate runs for asan, code coverage, and warning check. So you can do what you need to get things to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #754