-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding utils to code coverage #755
base: develop
Are you sure you want to change the base?
adding utils to code coverage #755
Conversation
How is this coming? |
There's still the matter of the memory problems with utils test, so I've been working to see if I can fix them so we can finally include them in the test coverage. It's been a little tricky. Is there a way to still include the tests in the test coverage without including them in the memory checks? If so, do you think it would be better to do that, then fix the memory issues in another PR? |
Yes, separate the code coverage from the memory issue. Turn off memory checking for utils, but leave on code coverage. Let me know if you need help. On another repo I found it useful to have separate runs for asan, code coverage, and warning check. So you can do what you need to get things to work. |
Fixes #754