Use g2c for AEC #739
Draft
Use g2c for AEC #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@edwardhartnett @AlysonStahl-NOAA I pushed from the wrong local copy of the updated code, so please ignore the old PR I closed and use this one, which is basically the same changes except it also includes my attempt to define Fortran interfaces with C bindings. |
Closed
|
@edwardhartnett would it make sense to put the Fortran interfaces under g2c itself so developers (including ourselves) don't have to duplicate code? I'm making some progress in sorting out handling pointers, char's, etc. as far as the ISO C bindings go. |
|
Yes good idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(reopening PR since it won't let me reuse the old one)
This PR is intended to add AEC functionality from g2c.
It needs testing, incl. unit testing, and I'm still not 100% on the C bindings, especially with respect to handling pointers.