Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

final updates for next v12.1.0 release #607

Merged
merged 1 commit into from
Jul 10, 2024
Merged

final updates for next v12.1.0 release #607

merged 1 commit into from
Jul 10, 2024

Conversation

jbathegit
Copy link
Collaborator

Fixes #586

@AlexanderRichert-NOAA @edwardhartnett As noted in some other threads, I'm still unsure about how (or whether?) to update the spack/package.py file to add a new entry for this new release. Or is that something that needs to be done post-release? I know the sha256 values in spack/package.py are different from the commit ids which correspond to the github tags for each release, but again I'm unsure about how or when to make that corresponding update to the file. Please let me know ASAP, or else I guess I'll just go ahead and do the next release after this PR is merged and with what we have for now.

@jbathegit jbathegit merged commit bdb497f into develop Jul 10, 2024
10 checks passed
@jbathegit jbathegit deleted the jba_newrelease branch July 10, 2024 15:05
@jbathegit
Copy link
Collaborator Author

@AlexanderRichert-NOAA @edwardhartnett As noted in some other threads, I'm still unsure about how (or whether?) to update the spack/package.py file to add a new entry for this new release. Or is that something that needs to be done post-release? I know the sha256 values in spack/package.py are different from the commit ids which correspond to the github tags for each release, but again I'm unsure about how or when to make that corresponding update to the file. Please let me know ASAP, or else I guess I'll just go ahead and do the next release after this PR is merged and with what we have for now.

Never mind, I eventually found the answer to this myself in #552 and made the corresponding update in #609

@edwardhartnett
Copy link
Contributor

I do the spack files after the release.

@jbathegit
Copy link
Collaborator Author

I do the spack files after the release.

@edwardhartnett as noted above, and since I'd never gotten a reply back, I did some further digging on my own and found (what I thought was?) the answer in #552. And with that information I correspondingly went ahead and submitted a new PR #609 after the v12.1.0 release.

Please take a look at the changes I made in #609, and if I missed anything then please feel free to submit your own commit on top of mine within that same PR, and we can just merge any needed changes from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new release v12.1.0
3 participants