Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed duplicate variable specification #551

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

AndrewEichmann-NOAA
Copy link
Collaborator

Tweak to recent refactor of vrfy task - made it so that config for plotter classes had variable specified only once, instead of twice when setting the colorbar bounds

@AndrewEichmann-NOAA AndrewEichmann-NOAA added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Aug 7, 2023
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera orion-GW-RT-Running Automated testing with global-workflow running on Orion and removed hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Aug 7, 2023
@emcbot
Copy link

emcbot commented Aug 7, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Mon Aug  7 22:19:55 UTC 2023 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Aug  7 23:21:27 UTC 2023
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Mon Aug  7 23:34:35 UTC 2023
Tests: 89% tests passed, 6 tests failed out of 53
	1588 - test_gdasapp_atm_jjob_var_init (Failed)
	1589 - test_gdasapp_atm_jjob_var_run (Failed)
	1590 - test_gdasapp_atm_jjob_var_final (Failed)
	1592 - test_gdasapp_atm_jjob_ens_run (Failed)
	1593 - test_gdasapp_atm_jjob_ens_final (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/551/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Aug 7, 2023
@emcbot
Copy link

emcbot commented Aug 7, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Mon Aug  7 17:17:22 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Aug  7 18:27:19 CDT 2023
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Mon Aug  7 18:47:04 CDT 2023
Tests: 89% tests passed, 6 tests failed out of 53
	1588 - test_gdasapp_atm_jjob_var_init (Failed)
	1589 - test_gdasapp_atm_jjob_var_run (Failed)
	1590 - test_gdasapp_atm_jjob_var_final (Failed)
	1592 - test_gdasapp_atm_jjob_ens_run (Failed)
	1593 - test_gdasapp_atm_jjob_ens_final (Failed)
Tests: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/551/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added orion-GW-RT-Failed Automated testing with global-workflow failed on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Aug 7, 2023
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@guillaumevernieres guillaumevernieres merged commit 8ca585b into develop Aug 8, 2023
17 checks passed
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/vrfy-refactor branch October 19, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hera-GW-RT-Failed Automated testing with global-workflow failed on Hera orion-GW-RT-Failed Automated testing with global-workflow failed on Orion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants