-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace all instances of pygw
with wxflow
#521
Conversation
Orion test Clone g-w branch
Repeat the above but use the current head of g-w
Reran
|
Six of the
As a test add
The last failed test,
The test passes with this addition to the script
While |
@RussTreadon-NOAA |
Please do not delete the branch |
Depending on how stable wxflow is, we can install it in the CI testing and add it to the Hera/Orion GDAS envs |
wxflow is exact copy of what's in the global workflow. |
Yes, thanks @aerorahul, I meant more as in how frequently will it be updated. If we expect PRs soon, then we need a different solution than installing in our virtual env but if it is a monthly+ cadence, then what I proposed above makes sense I think. |
As with any project, development will come in spurts as new features are requested. We will maintain (to the best of ability and intention) backward compatibility of the API. I don't expect any major disruptions, but I cannot promise minor adjustments won't be needed from time to time (not daily or weekly). |
reopening with updates. |
Automated Global-Workflow GDASApp Testing Results:
|
Automated Global-Workflow GDASApp Testing Results:
|
Automated Global-Workflow GDASApp Testing Results:
|
Automated Global-Workflow GDASApp Testing Results:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outstanding work @aerorahul !!!
The only real issue is this test: 1443 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY (Failed)
.
It times out. Happy to ignore for now.
The other failed test are related to "atm" jobs, we can definitely ignore those of course.
Orion test
A check of the log files in A change was committed to the UFO repository which sets the minimum CRTM version at 3.0.0. GDASApp uses an EMC-specific tag, v2.3-jedi.3_fix.
GDASApp was rebuilt and the
As a final check rerun all 49 GDASApp ctests. All 49 tests passed.
Summary: When GDASApp is built on Orion from |
Thank you @RussTreadon-NOAA for the validation. |
Thank you @RussTreadon-NOAA , this should be resolved through a PR just merged to UFO allowing CRTM 2.4 again. We will probably need to move to CRTM 2.4 in GDASApp, but that is probably okay at this point. @ADCollard @emilyhcliu any thoughts? |
I'm going to merge this in, since several downstream PRs now depend on it |
This PR:
pygw
references and replaces them with wxflow.See companion PR NOAA-EMC/global-workflow#1722