Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of "Convert to Structured Grid" to gdas #1167

Merged
merged 14 commits into from
Jun 12, 2024
Merged

Addition of "Convert to Structured Grid" to gdas #1167

merged 14 commits into from
Jun 12, 2024

Conversation

jrocha22
Copy link
Contributor

Added ConverttoStructuredGrid to gdas.cc

Juliette Rocha and others added 12 commits June 7, 2024 11:37
Add convert structured grid to gdas file
d4238ac
Fix typo, ConvertToStructuredGrid
72f2ab0
@jrocha22
Merge pull request #1 from jrocha22/feature/gdas-grid-edit
cebe890 
Feature/gdas grid edit
Attempt to correct structured grid addition
9104f5f
@jrocha22
Merge pull request #2 from jrocha22/feature/gdas-grid-edit
feb0a58 
Attempt to correct structured grid addition
Edit to Application recognizer converttostructuredgrid
685469d
@jrocha22
Merge pull request #3 from jrocha22/feature/gdas-grid-edit
ae565be 
Edit to Application recognizer converttostructuredgrid
Typo fix, convertstructuedgrid line 109
2bf6d0e
@jrocha22
Merge pull request #4 from jrocha22/feature/gdas-grid-edit
88d5ac5 
Typo fix, convertstructuedgrid line 109
Fixed comma error
c4c4aae
@jrocha22
Merge pull request #5 from jrocha22/feature/gdas-grid-edit
3c9b56d 
Fixed comma error
@CoryMartin-NOAA
Merge branch 'develop' into develop
a1d1c85
CoryMartin-NOAA
CoryMartin-NOAA reviewed Jun 12, 2024
View reviewed changes
mains/gdas.cc Outdated Show resolved Hide resolved
CatherineThomas-NOAA
CatherineThomas-NOAA reviewed Jun 12, 2024
View reviewed changes
mains/gdas.cc Outdated Show resolved Hide resolved
Juliette Rocha and others added 2 commits June 12, 2024 12:50
CatherineThomas-NOAA
CatherineThomas-NOAA approved these changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@CatherineThomas-NOAA CatherineThomas-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes. Approve.

@CoryMartin-NOAA CoryMartin-NOAA added the hera-GW-RT Queue for automated testing with global-workflow on Hera label Jun 12, 2024
@CoryMartin-NOAA
Copy link
Contributor

Kicking off the automated tests. If things look good enough, I'll merge!

@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Jun 12, 2024
@emcbot
Copy link

emcbot commented Jun 12, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Wed Jun 12 18:30:11 UTC 2024 on hfe12
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Jun 12 19:14:10 UTC 2024
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Wed Jun 12 19:41:22 UTC 2024
Tests: 100% tests passed, 0 tests failed out of 48

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Jun 12, 2024
@CoryMartin-NOAA CoryMartin-NOAA merged commit 9ffce97 into NOAA-EMC:develop Jun 12, 2024
8 checks passed
danholdaway added a commit that referenced this pull request Jun 13, 2024
@danholdaway
Merge branch 'feature/move_jcb' into feature/rename_atm
d30ba09 
* feature/move_jcb:
  Addition of "Convert to Structured Grid" to gdas (#1167)
  use gsibec tags/1.2.1 (#1164)
  Remove N21 from the aero obs list  (#1160)
  Add jcb and update jcb repos to remove submodules
  add jcb to gdasapp submods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoryMartin-NOAA CoryMartin-NOAA CoryMartin-NOAA left review comments

@danholdaway danholdaway danholdaway approved these changes

@CatherineThomas-NOAA CatherineThomas-NOAA CatherineThomas-NOAA approved these changes

Assignees
No one assigned
Labels
hera-GW-RT-Passed Automated testing with global-workflow successful on Hera
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jrocha22 @CoryMartin-NOAA @emcbot @danholdaway @CatherineThomas-NOAA