-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of "Convert to Structured Grid" to gdas #1167
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/gdas grid edit
Attempt to correct structured grid addition
Edit to Application recognizer converttostructuredgrid
Typo fix, convertstructuedgrid line 109
Fixed comma error
CoryMartin-NOAA
requested review from
CoryMartin-NOAA,
danholdaway and
CatherineThomas-NOAA
June 12, 2024 15:38
Rename App to converttostructuredgrid
CatherineThomas-NOAA
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes. Approve.
CoryMartin-NOAA
added
the
hera-GW-RT
Queue for automated testing with global-workflow on Hera
label
Jun 12, 2024
Kicking off the automated tests. If things look good enough, I'll merge! |
emcbot
added
hera-GW-RT-Running
Automated testing with global-workflow running on Hera
and removed
hera-GW-RT
Queue for automated testing with global-workflow on Hera
labels
Jun 12, 2024
danholdaway
approved these changes
Jun 12, 2024
Automated Global-Workflow GDASApp Testing Results:
|
emcbot
added
hera-GW-RT-Passed
Automated testing with global-workflow successful on Hera
and removed
hera-GW-RT-Running
Automated testing with global-workflow running on Hera
labels
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ConverttoStructuredGrid to gdas.cc