Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use gsibec tags/1.2.1 #1164

Merged
merged 1 commit into from
Jun 12, 2024
Merged

use gsibec tags/1.2.1 #1164

merged 1 commit into from
Jun 12, 2024

Conversation

RussTreadon-NOAA
Copy link
Contributor

Update sorc/gsibec to tags/1.2.1 to restore functionality of variational DA jobs in g-w C96C48_ufs_hybatmDA CI.

Fixes #1163

@RussTreadon-NOAA RussTreadon-NOAA self-assigned this Jun 11, 2024
@RussTreadon-NOAA
Copy link
Contributor Author

@givelberg or @guillaumevernieres - if you have time, would you review this PR?

PR #1138 changed the sorc/gsibec hash. This PR reverts the gsibec hash back to tags/1.2.1. This tag works with the other jedi repos in sorc and GDASApp templates and yaml.

guillaumevernieres
guillaumevernieres approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about this again @RussTreadon-NOAA and thanks for fixing what we broke.
I'll let you judge if you think the ci needs to run or not.

@RussTreadon-NOAA
Copy link
Contributor Author

Thank you, @guillaumevernieres . g-w CI run on Hera and passed!

@RussTreadon-NOAA RussTreadon-NOAA merged commit 2bd8ffc into develop Jun 12, 2024
5 checks passed
@RussTreadon-NOAA RussTreadon-NOAA deleted the feature/gsibec branch June 12, 2024 00:03
danholdaway added a commit that referenced this pull request Jun 13, 2024
@danholdaway
Merge branch 'feature/move_jcb' into feature/rename_atm
d30ba09 
* feature/move_jcb:
  Addition of "Convert to Structured Grid" to gdas (#1167)
  use gsibec tags/1.2.1 (#1164)
  Remove N21 from the aero obs list  (#1160)
  Add jcb and update jcb repos to remove submodules
  add jcb to gdasapp submods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaumevernieres guillaumevernieres guillaumevernieres approved these changes

Assignees

@RussTreadon-NOAA RussTreadon-NOAA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revert sorc/gsibec back to gsibec tags/1.2.1
2 participants
@RussTreadon-NOAA @guillaumevernieres