Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving vrfy plots and Fixing blank plots #1145

Merged
merged 11 commits into from
Jun 20, 2024
Merged

Improving vrfy plots and Fixing blank plots #1145

merged 11 commits into from
Jun 20, 2024

Conversation

apchoiCMD
Copy link
Collaborator

This PR includes,

@apchoiCMD apchoiCMD changed the title Improve Vrfy Plots partially Improving vrfy plots and Fixing blank plots Jun 4, 2024
@RussTreadon-NOAA RussTreadon-NOAA mentioned this pull request Jun 7, 2024
Closed
@guillaumevernieres
Copy link
Contributor

guillaumevernieres commented Jun 10, 2024 •
edited by apchoiCMD
Loading

After a bit of figure browsing:

  • Something is wrong with hi (ice thickness). It looks way too thick, check if it's a plotting issue ... Or a model issue 😨
  • Adjust colorbar for hs (snow thickness)
  • salinity colormap looks good but colorbar needs improvement
  • We need to add zonal and meridional sections of the background
  • Scatter size for Satellites obs's plot
  • ...

@apchoiCMD
Copy link
Collaborator Author

List that we have to look at-

  • We need to able to click though the html what we want to see
  • Colorbar issue for min and max
  • Achieve COMROT for the future by tar them to HPSS

@apchoiCMD
Copy link
Collaborator Author

Latest plots are here

/scratch1/NCEPDEV/da/Mindo.Choi/workflow_06032024/global-workflow/sorc/gdas.cd/build/gdas/test/gw-ci/GFSv17-3DVAR-C384mx025/COMROOT/GFSv17-3DVAR-C384mx025/gdas.20210630/06/analysis/ocean/vrfy

@apchoiCMD apchoiCMD marked this pull request as ready for review June 20, 2024 15:26
@apchoiCMD
Copy link
Collaborator Author

Markersize = 0 with eva will not generate the plots, it seems 1 is minimum size for map_plots

guillaumevernieres
guillaumevernieres previously approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few minor comments. Is it still failing when running the ci?

ush/soca/soca_vrfy.py Outdated Show resolved Hide resolved
ush/soca/soca_vrfy.py Outdated Show resolved Hide resolved
@apchoiCMD
Copy link
Collaborator Author

apchoiCMD commented Jun 20, 2024 •
edited
Loading

Looks good, just a few minor comments. Is it still failing when running the ci?

No, it shouldn't be commented out and some bounds also are added,, now doing a final check-ups for you mentioned. Will push modified one soon-

@apchoiCMD apchoiCMD added the hera-GW-RT Queue for automated testing with global-workflow on Hera label Jun 20, 2024
@guillaumevernieres guillaumevernieres merged commit c0de814 into develop Jun 20, 2024
7 checks passed
@guillaumevernieres guillaumevernieres deleted the feature/vrfy-plot branch June 20, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaumevernieres guillaumevernieres guillaumevernieres approved these changes

@JohnSteffen-NOAA JohnSteffen-NOAA Awaiting requested review from JohnSteffen-NOAA

@AndrewEichmann-NOAA AndrewEichmann-NOAA Awaiting requested review from AndrewEichmann-NOAA

Assignees
No one assigned
Labels
hera-GW-RT Queue for automated testing with global-workflow on Hera
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bkgerr Plots from Marine Verify Task are blank
2 participants
@apchoiCMD @guillaumevernieres