-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken metrics part 1 #31
Commits on Sep 13, 2023
-
Document the bgp-tcp-in unit settings, and cleanup dangling footnotes…
…, fix typos and make various improvements to the config file text and structure.
Configuration menu - View commit details
-
Copy full SHA for b832532 - Browse repository at this point
Copy the full SHA b832532View commit details -
Configuration menu - View commit details
-
Copy full SHA for 88ead40 - Browse repository at this point
Copy the full SHA 88ead40View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4753271 - Browse repository at this point
Copy the full SHA 4753271View commit details -
Initial MVP default config support.
When run without --config the embedded copy of etc/rotonda.conf is used instead, and targets.proxy is removed if --proxy-destination is not supplied on the command line. If --bgp-listen or --bmp-listen are supplied on the command line they override the BMP and BGP listen settings in the embedded config. - Allow BGP peers to be missing.
Configuration menu - View commit details
-
Copy full SHA for d682a54 - Browse repository at this point
Copy the full SHA d682a54View commit details
Commits on Sep 14, 2023
-
- Add missing semi-colon. - Filter out not in.
Configuration menu - View commit details
-
Copy full SHA for 505486e - Browse repository at this point
Copy the full SHA 505486eView commit details -
Configuration menu - View commit details
-
Copy full SHA for eabc6b7 - Browse repository at this point
Copy the full SHA eabc6b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 43e7142 - Browse repository at this point
Copy the full SHA 43e7142View commit details -
Log at info rather than debug level that we are listening for HTTP co…
…nnections on a particular socket.
Configuration menu - View commit details
-
Copy full SHA for 94a03f9 - Browse repository at this point
Copy the full SHA 94a03f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 20d2879 - Browse repository at this point
Copy the full SHA 20d2879View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64f7d7c - Browse repository at this point
Copy the full SHA 64f7d7cView commit details -
FIX: Store HTTP provider relative base URLs so that the router info p…
…age can link to the actual RIB query HTTP API rather than incorrectly assume a fixed path of /prefixes/.
Configuration menu - View commit details
-
Copy full SHA for b4c84c4 - Browse repository at this point
Copy the full SHA b4c84c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd1a128 - Browse repository at this point
Copy the full SHA dd1a128View commit details -
Configuration menu - View commit details
-
Copy full SHA for 67b76d6 - Browse repository at this point
Copy the full SHA 67b76d6View commit details
Commits on Sep 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b59fe39 - Browse repository at this point
Copy the full SHA b59fe39View commit details -
Configuration menu - View commit details
-
Copy full SHA for 321d2f0 - Browse repository at this point
Copy the full SHA 321d2f0View commit details -
Merge branch 'add-default-mvp-config' into fix-broken-router-info-pag…
…e-prefixes-query-link
Configuration menu - View commit details
-
Copy full SHA for 5096f6c - Browse repository at this point
Copy the full SHA 5096f6cView commit details
Commits on Sep 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8dabed6 - Browse repository at this point
Copy the full SHA 8dabed6View commit details
Commits on Sep 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3b5c78b - Browse repository at this point
Copy the full SHA 3b5c78bView commit details -
Adjust the config syntax to use filter name references to filters def…
…ined in roto scripts loaded from a roto script directory. - Refactors roto script file reading from the units/targets to the Manager. - Checks script loading, compilation and valid filter names at config load time instead of at filter execution time. - Add MVP behaviour tests (WIP). - Introduces a FilterName type.
Configuration menu - View commit details
-
Copy full SHA for 1270935 - Browse repository at this point
Copy the full SHA 1270935View commit details
Commits on Sep 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c4af03a - Browse repository at this point
Copy the full SHA c4af03aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f396ec - Browse repository at this point
Copy the full SHA 6f396ecView commit details -
And mark the process_metrics as unused, but leave them there for now …
…in case I return to this later.
Configuration menu - View commit details
-
Copy full SHA for a57ec2a - Browse repository at this point
Copy the full SHA a57ec2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 77884bb - Browse repository at this point
Copy the full SHA 77884bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for f66a9f5 - Browse repository at this point
Copy the full SHA f66a9f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for e4d5e55 - Browse repository at this point
Copy the full SHA e4d5e55View commit details -
Configuration menu - View commit details
-
Copy full SHA for d1f6f98 - Browse repository at this point
Copy the full SHA d1f6f98View commit details -
Configuration menu - View commit details
-
Copy full SHA for 312480a - Browse repository at this point
Copy the full SHA 312480aView commit details -
Permit filters to be missing in MVP mode, as the user may not have th…
…e required .roto files, e.g. if running from `cargo install`. Cleanup config initialisation and standard variable naming.
Configuration menu - View commit details
-
Copy full SHA for 4b6cf0c - Browse repository at this point
Copy the full SHA 4b6cf0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b543e7 - Browse repository at this point
Copy the full SHA 9b543e7View commit details -
Don't abort when using the embedded config if the defined `roto_scrip…
…ts_dir` dir `etc` doesn't exist. This change had several knock on effects: - Introduced RotoError::LoadError. - Upgrade clap crate to fix bug with clap switcing help on own line or not even when disabled. - Upgrade toml crate to fix inconsistent line breaks in diagnostic dump of post-processed config TOML. - Adjust position handling in `Marked` due to changes in serde_spanned pulled in by other crate upgrades. - Added new cmd line arg --print-config-and-exit and introduced `Terminated` for use in cases where `ExitError` wrongly limits us to just an error exit rather than a normal exit. - Various minor tweaks to the clap config for improved read and usability. - Log when exiting.
Configuration menu - View commit details
-
Copy full SHA for d10642d - Browse repository at this point
Copy the full SHA d10642dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ef5528 - Browse repository at this point
Copy the full SHA 7ef5528View commit details
Commits on Sep 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ab077b7 - Browse repository at this point
Copy the full SHA ab077b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for b68ceb9 - Browse repository at this point
Copy the full SHA b68ceb9View commit details -
Add the MQTT target to match the MVP diagram, and a command line argu…
…ment to set the destination in MVP mode. Also make the MQTT unit consistent with the BMP proxy unit by having a destination setting rather than individual server_host and server_port settings.
Configuration menu - View commit details
-
Copy full SHA for f874c09 - Browse repository at this point
Copy the full SHA f874c09View commit details -
Configuration menu - View commit details
-
Copy full SHA for e6fb6c1 - Browse repository at this point
Copy the full SHA e6fb6c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for c316a25 - Browse repository at this point
Copy the full SHA c316a25View commit details -
Apply the Cargo mqtt feature guard consistently also in new code by s…
…imply removing the Cargo feature entirely.
Configuration menu - View commit details
-
Copy full SHA for f8bdf10 - Browse repository at this point
Copy the full SHA f8bdf10View commit details -
Configuration menu - View commit details
-
Copy full SHA for bdba816 - Browse repository at this point
Copy the full SHA bdba816View commit details -
Configuration menu - View commit details
-
Copy full SHA for efc4568 - Browse repository at this point
Copy the full SHA efc4568View commit details -
Configuration menu - View commit details
-
Copy full SHA for 940b645 - Browse repository at this point
Copy the full SHA 940b645View commit details -
RIB unit reconfigure should follow changes to the Roto filter name it…
… is supposed to use.
Configuration menu - View commit details
-
Copy full SHA for d325dc4 - Browse repository at this point
Copy the full SHA d325dc4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 17ad67c - Browse repository at this point
Copy the full SHA 17ad67cView commit details -
Configuration menu - View commit details
-
Copy full SHA for fb74130 - Browse repository at this point
Copy the full SHA fb74130View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a422c4 - Browse repository at this point
Copy the full SHA 5a422c4View commit details
Commits on Oct 2, 2023
-
Remove the post-filters, they were a misunderstanding in the absence …
…of the no longer absent filtering within the BGP unit itself.
Configuration menu - View commit details
-
Copy full SHA for 1557d97 - Browse repository at this point
Copy the full SHA 1557d97View commit details -
Configuration menu - View commit details
-
Copy full SHA for a9d38c1 - Browse repository at this point
Copy the full SHA a9d38c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6af63da - Browse repository at this point
Copy the full SHA 6af63daView commit details -
Configuration menu - View commit details
-
Copy full SHA for eb7095c - Browse repository at this point
Copy the full SHA eb7095cView commit details
Commits on Oct 3, 2023
-
Add a special metric output format for use by unit tests, and a callb…
…ack fired on each VM exec that rejects the input (to enable easy counting of filtered out input messages), and remove support for metric types we don't need. Use the new callback to invoke the till now unused message_filtered() status reporter fn.
Configuration menu - View commit details
-
Copy full SHA for 4511262 - Browse repository at this point
Copy the full SHA 4511262View commit details -
Configuration menu - View commit details
-
Copy full SHA for 79e01cd - Browse repository at this point
Copy the full SHA 79e01cdView commit details
Commits on Oct 4, 2023
-
Remove the bmp_in_connection_count metric as connections are handled …
…by bmp_tcp_in while this metric is based on BMP initiation messages received, so this is (a) misleading and (b) doesn't work anyway as when the sys name changes so can the router id and thus the changed metric would be in a different metric set, there'd be no effect on the previous metric.
Configuration menu - View commit details
-
Copy full SHA for 7852503 - Browse repository at this point
Copy the full SHA 7852503View commit details -
Follow changes in router id caused by a new sysName received by a sub…
…sequent BMP Initiation Message.
Configuration menu - View commit details
-
Copy full SHA for 7d1cba7 - Browse repository at this point
Copy the full SHA 7d1cba7View commit details -
Make test metrics easier to query, and add initial tests for the one …
…and only remaining bmp-in metric. TODO: add a test showing bmp_in_num_invalid_bmp_messages increasing.
Configuration menu - View commit details
-
Copy full SHA for 1ee9a34 - Browse repository at this point
Copy the full SHA 1ee9a34View commit details -
Remove the footgun of having to initialiize metrics per router, just …
…ensure they are initialized on first use, otherwise metrics get lost.
Configuration menu - View commit details
-
Copy full SHA for 980891a - Browse repository at this point
Copy the full SHA 980891aView commit details -
Add a test showing that invalid BMP messages cause the bmp_in_num_inv…
…alid_bmp_messages counter to increase.
Configuration menu - View commit details
-
Copy full SHA for d860db2 - Browse repository at this point
Copy the full SHA d860db2View commit details
Commits on Oct 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for bba52fd - Browse repository at this point
Copy the full SHA bba52fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for ed9aad7 - Browse repository at this point
Copy the full SHA ed9aad7View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8a409d - Browse repository at this point
Copy the full SHA d8a409dView commit details -
Sort test metric output for easier reading when inspecting the conten…
…ts manually during development.
Configuration menu - View commit details
-
Copy full SHA for 96dd214 - Browse repository at this point
Copy the full SHA 96dd214View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb7b53b - Browse repository at this point
Copy the full SHA eb7b53bView commit details -
Mock the TcpStream as well so that we can accept a simulated connecti…
…on to test the `bgp_tcp_in_connection_accepted_count` metric.
Configuration menu - View commit details
-
Copy full SHA for 09a8713 - Browse repository at this point
Copy the full SHA 09a8713View commit details -
Configuration menu - View commit details
-
Copy full SHA for a7e355d - Browse repository at this point
Copy the full SHA a7e355dView commit details -
Also test the connection lost and disconnected bgp-tcp-in metrics by …
…using a mock BGP `Session`.
Configuration menu - View commit details
-
Copy full SHA for f918b9c - Browse repository at this point
Copy the full SHA f918b9cView commit details
Commits on Oct 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8aa601b - Browse repository at this point
Copy the full SHA 8aa601bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 48fd954 - Browse repository at this point
Copy the full SHA 48fd954View commit details
Commits on Oct 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d881c89 - Browse repository at this point
Copy the full SHA d881c89View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ea5c25 - Browse repository at this point
Copy the full SHA 2ea5c25View commit details
Commits on Oct 12, 2023
-
Fix broken links in bmp-in HTML interface, and name the RIB instances…
… whose APIs are linked to.
Configuration menu - View commit details
-
Copy full SHA for 2de35f7 - Browse repository at this point
Copy the full SHA 2de35f7View commit details -
Merge branch 'fix-broken-router-info-page-prefixes-query-link' into f…
…ix-broken-metrics
Configuration menu - View commit details
-
Copy full SHA for 1b30295 - Browse repository at this point
Copy the full SHA 1b30295View commit details -
Configuration menu - View commit details
-
Copy full SHA for e6ae4e5 - Browse repository at this point
Copy the full SHA e6ae4e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3db6f53 - Browse repository at this point
Copy the full SHA 3db6f53View commit details -
Configuration menu - View commit details
-
Copy full SHA for c30420a - Browse repository at this point
Copy the full SHA c30420aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 75345a5 - Browse repository at this point
Copy the full SHA 75345a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b0abd6e - Browse repository at this point
Copy the full SHA b0abd6eView commit details -
Rename fn to make it clearer that its results are only for now, and l…
…ater results may be different if called again.
Configuration menu - View commit details
-
Copy full SHA for 0cda43b - Browse repository at this point
Copy the full SHA 0cda43bView commit details -
Introduce the concept of fatal vs non-fatal I/O errors and don't drop…
… the BMP TCP input receiver on non-fatal errors (otherwise loss of the receiver causes the router read loop to abort anyway).
Configuration menu - View commit details
-
Copy full SHA for f423b75 - Browse repository at this point
Copy the full SHA f423b75View commit details -
Configuration menu - View commit details
-
Copy full SHA for 90f4844 - Browse repository at this point
Copy the full SHA 90f4844View commit details -
Configuration menu - View commit details
-
Copy full SHA for e636a71 - Browse repository at this point
Copy the full SHA e636a71View commit details -
Configuration menu - View commit details
-
Copy full SHA for f42e5a8 - Browse repository at this point
Copy the full SHA f42e5a8View commit details
Commits on Oct 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8aa7755 - Browse repository at this point
Copy the full SHA 8aa7755View commit details -
Configuration menu - View commit details
-
Copy full SHA for 01ffb8f - Browse repository at this point
Copy the full SHA 01ffb8fView commit details