Fix filter reloading #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, fix typos and make various improvements to the config file text and structure.
When run without --config the embedded copy of etc/rotonda.conf is used instead, and targets.proxy is removed if --proxy-destination is not supplied on the command line. If --bgp-listen or --bmp-listen are supplied on the command line they override the BMP and BGP listen settings in the embedded config. - Allow BGP peers to be missing.
- Add missing semi-colon. - Filter out not in.
…nnections on a particular socket.
…ined in roto scripts loaded from a roto script directory. - Refactors roto script file reading from the units/targets to the Manager. - Checks script loading, compilation and valid filter names at config load time instead of at filter execution time. - Add MVP behaviour tests (WIP). - Introduces a FilterName type.
…in case I return to this later.
…e required .roto files, e.g. if running from `cargo install`. Cleanup config initialisation and standard variable naming.
…ts_dir` dir `etc` doesn't exist. This change had several knock on effects: - Introduced RotoError::LoadError. - Upgrade clap crate to fix bug with clap switcing help on own line or not even when disabled. - Upgrade toml crate to fix inconsistent line breaks in diagnostic dump of post-processed config TOML. - Adjust position handling in `Marked` due to changes in serde_spanned pulled in by other crate upgrades. - Added new cmd line arg --print-config-and-exit and introduced `Terminated` for use in cases where `ExitError` wrongly limits us to just an error exit rather than a normal exit. - Various minor tweaks to the clap config for improved read and usability. - Log when exiting.
…ment to set the destination in MVP mode. Also make the MQTT unit consistent with the BMP proxy unit by having a destination setting rather than individual server_host and server_port settings.
…imply removing the Cargo feature entirely.
… is supposed to use.
* Update rotonda-* deps. * Roto compiler API changes, incl. compile only once instead of on first use in every thread. * Typo fixes and improvements in comments. Other: * Nothing to do message on SIGHUP. * Bug fix: When removing a loaded script, scoped scripts that reference the removed parent script should NOT be retained. * Trigger CI on push to main and on PR changes, not just on demand. * For CI ensure the correct Rust toolchain version is installed (as it is less likely to be kept updated in a self-hosted runner). * Applied some Clippy suggestions. --------- Co-authored-by: ximon18 <[email protected]>
…uiring VM rebuild. TODO: Add a unit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check on filter reload (rather than init) for filter modification requiring VM rebuild.
TODO: Add a unit test.