FIx broken router info page prefixes query link. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, fix typos and make various improvements to the config file text and structure.
When run without --config the embedded copy of etc/rotonda.conf is used instead, and targets.proxy is removed if --proxy-destination is not supplied on the command line. If --bgp-listen or --bmp-listen are supplied on the command line they override the BMP and BGP listen settings in the embedded config. - Allow BGP peers to be missing.
- Add missing semi-colon. - Filter out not in.
…nnections on a particular socket.
…age can link to the actual RIB query HTTP API rather than incorrectly assume a fixed path of /prefixes/.
…e-prefixes-query-link
ximon18
force-pushed
the
fix-broken-router-info-page-prefixes-query-link
branch
from
1060231
to
5096f6c
Compare
density215
pushed a commit
that referenced
this pull request
Dec 8, 2023
Store HTTP provider relative base URLs so that the router info page can link to the actual RIB query HTTP API rather than incorrectly assume a fixed path of /prefixes/.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The /routers/<router_id> HTML pages will list announced prefixes by peer, if any, and for each prefix a hyperlink is provided to the prefix query API to make it easy to explore the loaded data.
Until now that hyperlink wrongly assumed that the prefix API HTTP relative URL is
/prefixes/but with the changes in #19 there is no prefix API at that relative URL and that assumption is no longer valid.This PR updates the generated hyperlink to refer to the actual location of the prefix API (or APIs if there are multiple RIB units) and introduces tracking of which component type registered a HTTP handler for which base URL so that the correct set of base URLs can be enumerated when generating the links.