Skip to content

Commit

Permalink
Fix and scale up GH workflows by switching to GH hosted runners (#75)
Browse files Browse the repository at this point in the history
* Use GH hosted runner for all workflows.
* Pin to Ubuntu 22.04.
* Bump Alpine to hopefully work around the MQTT compilation failure.
  • Loading branch information
ximon18 authored Jan 9, 2024
1 parent bbb9dfb commit eb6ae63
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ env:

jobs:
build:
runs-on: self-hosted
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v3
- name: Ensure correct Rust toolchain version
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
coverage:
name: coverage
if: ${{ github.event.workflow_run.conclusion == 'success' || github.event_name == 'workflow_dispatch' }}
runs-on: self-hosted
runs-on: ubuntu-22.04
steps:
- name: Checkout repository
uses: actions/checkout@v4
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/pkg-min.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ jobs:
uses: NLnetLabs/ploutos/.github/workflows/pkg-rust.yml@v7

with:
runs_on: self-hosted

#package_build_rules: pkg/rules/packages-to-build.yml
package_test_scripts_path: pkg/test-scripts/test-<package>.sh

Expand Down
5 changes: 0 additions & 5 deletions .github/workflows/pkg.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,6 @@ jobs:
# DOCKER_HUB_TOKEN: ${{ secrets.DOCKER_HUB_TOKEN }}

with:
# TODO: When ready to make this repository public, remove this `runs_on` when this repository is made public.
# Until then run on self-hosted runners at the office to avoid consuming the GitHub Actions credits that we
# also use for other things because private repositories use a limited budget of per-organization credits.
runs_on: self-hosted

docker_org: nlnetlabs
docker_repo: rotonda
docker_build_rules: pkg/rules/docker-images-to-build.yml
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ ARG MODE=build
# ========
#
# Only used when MODE=build.
ARG BASE_IMG=alpine:3.18
ARG BASE_IMG=alpine:3.19


# CARGO_ARGS
Expand Down

0 comments on commit eb6ae63

Please sign in to comment.