Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

send+sync on mergeupdate #31

Merged
merged 1 commit into from
Sep 21, 2023
Merged

send+sync on mergeupdate #31

merged 1 commit into from
Sep 21, 2023

Conversation

density215
Copy link
Member

@density215 density215 commented Sep 20, 2023 •
edited
Loading

  • Add Sync + Send trait boundaries on the MergeUpdate trait, so that RotoRib in Roto can be Send + Sync as well.
  • Remove summary() from the Meta trait, it's now only a marker Trait, setting some trait boundaries on it.

ximon18
ximon18 approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@ximon18 ximon18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, LGTM.

@density215 density215 merged commit fa4950e into main Sep 21, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ximon18 ximon18 ximon18 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@density215 @ximon18