-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track $INCLUDE dependencies #377
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to keep track of include files. It looks okay.
/* give a description here of why we maintain a "list" of file | ||
* names */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment seems to be todo.
void | ||
namedb_zone_free_filenames(namedb_type *db, zone_type* zone) | ||
{ | ||
assert(!zone->includes.paths || !zone->filename); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not get this assertion. It seems that the zone could have a filename, and that while parsing includes.paths can get filled with include files. That makes them both not NULL and that would fail this assertion.
VERBOSITY(3, (LOG_INFO, "zonefile %s is not modified", | ||
fname)); | ||
return; | ||
} else if(zone_fname && strcmp(zone_fname, fname) >= 0 && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name comparison is wrong, it seems.
} else if(zone_fname && strcmp(zone_fname, fname) >= 0 && | |
} else if(zone_fname && strcmp(zone_fname, fname) == 0 && |
What it says on the tin. Fixes #57.