Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin numpy<2.0 for PyPI install issue #600

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Conversation

anissa111
Copy link
Member

@anissa111 anissa111 commented Apr 23, 2024

PR Summary

Temporary fix for #598

So, due to a pip bug (see Unidata/cftime#327), sometimes pre-release versions get installed, which is what's messing with our release tests. Since numpy 2.0 isn't actually released yet, I don't anticipate any problems with this pin until numpy 2.0 is fully released and generally compatible.

PR Checklist

General

  • Make an issue if one doesn't already exist
  • Link the issue this PR resolves by adding closes #XXX to the PR description where XXX is the number of the issue.
  • Add a brief summary of changes to docs/release-notes.rst in a relevant section for the next unreleased release. Possible sections include: Documentation, New Features, Bug Fixes, Internal Changes, Breaking Changes/Deprecated
  • Add appropriate labels to this PR
  • Make your changes in a forked repository rather than directly in this repo
  • Passes precommit. To set up on your local, run pre-commit install from the top level of the repository. To manually run pre-commits, use pre-commit run --all-files and re-add any changed files before committing again and pushing.
  • If needed, squash and merge PR commits into a single commit to clean up commit history

@anissa111 anissa111 added bug Something isn't working dependencies Pull requests that update a dependency file testing Issue related to testing labels Apr 23, 2024
@anissa111 anissa111 changed the title temp-numpy-pin Pin numpy<2.0 for PyPI install issue Apr 23, 2024
@anissa111 anissa111 merged commit fffe34e into NCAR:main Apr 23, 2024
12 checks passed
@anissa111 anissa111 deleted the temp-numpy-pin branch April 23, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file testing Issue related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants