Fix/image format is null export image or elevations example #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed bug where the format chosen for exporting images was always returning null, preventing the user from exporting any images except for elevations. - Added more file filters to the Swing FileChooser and added a hashmap for matching those extensions to mime types It would be great though if there was another example of how to make these export functions used the locally cached map tiles instead of requesting them repeatedly from a WMS endpoint. I know the elevations are exported by reading local data, but for some reason the Image capture functions don't seem to be able to read / access / or modify a local cache and default to always making a new request from external servers.
- Removed print statements and updated formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Filling out this template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the
maintainer's discretion.
Description of the Change
Why Should This Be In Core?
Giving new developers and users an example of how to export georeferenced images from WWD will greatly help their efforts in creating specialized versions of WWD, or how to add this functionality to their current WWD products.
Benefits
Developers will be able to build off of this example and produce locally saved imagery.
Potential Drawbacks
If any of the WMS endpoints end up not supporting the mimetypes I added (like how arcGIS supports image/tiff but not image/tif) then those extensions would have to be removed from the added user options.
Applicable Issues
It would be great though if there was another example of how to make these export functions used the locally cached map tiles instead of requesting them repeatedly from a WMS endpoint. I know the elevations are exported by reading local data, but for some reason the Image capture functions don't seem to be able to read / access / or modify a local cache and instead it defaults to making new WMS requests.