Put tile urls for datasets #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hanbyul-here
commented
Aug 16, 2023
danielfdsilva
force-pushed
the
feature/titiler-link
branch
from
1194307
to
cde52f1
Compare
danielfdsilva
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
This was a great base to start. 🎉 I rebased the work after merging the coordinates PR. (be sure to reset your branch)
- I noticed that the xyz endpoint was actually the tilejson, which may not be exactly what we want, so I fetched and stored the xyz url.
- I did not change anything about the wmts as I'm not sure about the format.
- Added support for the vector data tile endpoint
- Tweaked the widget styles and the different types
I think this is good to go! (maybe double check the wmts)
hanbyul-here
commented
Aug 17, 2023
app/scripts/components/common/mapbox/layers/raster-timeseries.tsx
Outdated
Show resolved
Hide resolved
hanbyul-here
force-pushed
the
feature/titiler-link
branch
from
252f494
to
d381a05
Compare
|
@anayeaye brought up a good point that custom color formula can make it look like it is not working (ex. color_formula=gamma+r+1.05.). I don't think this should be a blocker, but worth noting. Thanks for testing the features 🙇 🙇 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on : #620
Close #594