Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/multiple-contact-reviewers #559

Merged
merged 5 commits into from
Oct 13, 2023

Conversation

kamicut
Copy link
Collaborator

@kamicut kamicut commented Oct 11, 2023

  • Remove reviewer info UI in edit mode
  • Add checkbox in Document Roles for contacts that allows contacts to be 'Document Reviewer'
  • View mode for reviewer info that pulls from contact roles

Also sorts contacts in document by Corresponding Author NASA-IMPACT/nasa-apt#709

@kamicut
Copy link
Collaborator Author

kamicut commented Oct 12, 2023

Adds a reviewer in the view mode and pdf-preview (not journal-pdf) similar to a contact card. To add a reviewer, use the 'Document Reviewer' checkbox in the roles.

edit mode

image

view mode

image

pdf preview

image

@kamicut kamicut marked this pull request as ready for review October 12, 2023 19:03
Copy link
Member

@wrynearson wrynearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wrynearson wrynearson merged commit d5c62f8 into develop Oct 13, 2023
14 checks passed
@wrynearson wrynearson deleted the feature/multiple-contact-reviewers branch October 13, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants