Process Pull Request

Jump to bottom

Thomas Scheffler edited this page Jan 3, 2018 · 2 revisions

How to process pull request

check if pull request is made for the correct target branch (look at Jira Ticket), else close the pull request
check if commit author is clickable and matches a GitHub account
check if commit message format is correct (MCR-0000 TicketDescription CommitDescription)
wait for Travis CI to give green, sometimes a restart of the test build can make it green

If any check above is missing let the request open and the author fix it first.

in case of LTS merge to master leave the PR for yagee-de
in case the PR as a single commit, make a Rebase in all other cases a Squash and merge