Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: send BeforeDisconnectEvent before disconnecting clients #5077

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

jdrueckert
Copy link
Member

Contains

A new BeforeDisconnectEvent event that is sent before disconnecting clients to allow, e.g. component clean-ups on the disconnecting player's entity.

Required by Terasology/LightAndShadow#256

@github-actions github-actions bot added the Type: Improvement Request for or addition/enhancement of a feature label Nov 6, 2022
jdrueckert added a commit to Terasology/LightAndShadow that referenced this pull request Nov 6, 2022
- create PlayerExitedArenaEvent
- on arena exit remove AllowShopScreenComponent (players only need the shop in-game)
- move check for condition changes that trigger a phase change into LASSystem
- switch player to white team instead of removing LASTeam component
- trigger arena exit clean up actions for disconnecting clients before they are disconnected (requires MovingBlocks/Terasology#5077)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement Request for or addition/enhancement of a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant