Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expand attribute scheme to allow combining meshdata #4900

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

pollend
Copy link
Member

@pollend pollend commented Sep 10, 2021

added a way to combine mesh data from a different mesh. I use the the last position in the buffer to determine where the last vertex was so I can stitch the mesh together. Any fields that are unused in both meshes are kept empty else I allocate out to that limit.

I want to go with something less opinionated. We have a couple factories but their use cases are limited and are used in very limited scenarios. my thought is to introduce a set of base primitives plus some useful operations and the rest will be up to the discretion of the developer.

@github-actions github-actions bot added the Type: Improvement Request for or addition/enhancement of a feature label Sep 10, 2021
@pollend pollend force-pushed the feat/add-combine-operation-standard-mesh-data branch from b07c797 to a3340ec Compare September 10, 2021 04:21
@pollend pollend marked this pull request as ready for review September 10, 2021 04:23
@pollend pollend marked this pull request as draft September 10, 2021 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement Request for or addition/enhancement of a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant