FSM 内部执行外部函数出现异常时不应崩溃 #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nonebot-bison ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for nonebot-bison ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #616 +/- ##
==========================================
+ Coverage 85.45% 85.64% +0.19%
==========================================
Files 91 91
Lines 4793 4822 +29
==========================================
+ Hits 4096 4130 +34
+ Misses 697 692 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
AzideCupric
force-pushed
the
fix/fsm-except
branch
from
2d3186e
to
d2ed7b7
Compare
|
是不是应该在每个 action 里处理错误处理，在外层如果检测到发生错误就直接 reset |
reset与否我认为应该让具体的使用场景抉择，而不是包办 |
|
这样，默认的行为是 exception 之后 fsm 报错。然后外面包一个 wrapper？如果发生错误就创建新的 fsm |
AzideCupric
force-pushed
the
fix/fsm-except
branch
from
7608082
to
2d54625
Compare
felinae98
approved these changes
Sep 17, 2024
Comment on lines
122
to
126
| def __init__(self, graph: StateGraph[TState, TEvent, TAddon], addon: TAddon): ... | ||
|
|
||
| @overload | ||
| def __init__(self, graph: StateGraph[TState, TEvent, TAddon], addon: TAddon, *, transfer_anyway: bool = ...): | ||
| """if, transfer_anyway` is True, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
避免因网络不佳等原因使 action 抛出异常导致 FSM 异常终止