Feat: transitFeedSyncProcessor implmentation #760
Draft
+1,144
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added logic to determine if a feed is "new" or requires an "update" based on database checks.
- Integrated new `payload_type` field in `TransitFeedSyncPayload` to track the status of each feed ("new" or "update").
- Implemented checks for `external_id` in `public.externalid` table and corresponding `feed_url` in `public.feed` table.
- Filtered out feeds with HTTP status codes 404 and 500, as well as those from Japan and France.
- Added methods for fetching and extracting data from the TransitLand API, combining operator and feed data to prepare payloads.
…nal ID checks
- Added logic to determine if a feed is "new" or requires an "update" based on database checks.
- Integrated new `payload_type` field in `TransitFeedSyncPayload` to track the status of each feed ("new" or "update").
- Implemented checks for `external_id` in `public.externalid` table and corresponding `feed_url` in `public.feed` table.
- Filtered out feeds with HTTP status codes 404 and 500, as well as those from Japan and France.
- Added methods for fetching and extracting data from the TransitLand API, combining operator and feed data to prepare payloads.
…nal ID checks
- Added logic to determine if a feed is "new" or requires an "update" based on database checks.
- Integrated new `payload_type` field in `TransitFeedSyncPayload` to track the status of each feed ("new" or "update").
- Implemented checks for `external_id` in `public.externalid` table and corresponding `feed_url` in `public.feed` table.
- Filtered out feeds with HTTP status codes 404 and 500, as well as those from Japan and France.
- Added methods for fetching and extracting data from the TransitLand API, combining operator and feed data to prepare payloads.
- Added logic to determine if a feed is "new" or requires an "update" based on database checks.
- Integrated new `payload_type` field in `TransitFeedSyncPayload` to track the status of each feed ("new" or "update").
- Implemented checks for `external_id` in `public.externalid` table and corresponding `feed_url` in `public.feed` table.
- Filtered out feeds with HTTP status codes 404 and 500, as well as those from Japan and France.
- Added methods for fetching and extracting data from the TransitLand API, combining operator and feed data to prepare payloads.
|
|
…stop_id 2. adjusted payload to reflect external_id update
Incorporated URL status check and merged feed sync data using pandas DataFrames for enhanced processing. Refactored process_sync() function to include filtering, grouping, and data extraction improvements, leading to more efficient and accurate feed sync operations.
… feat/transitland-feed-sync
Unit tests to verify the functionality of TransitFeedSyncProcessor, covering data retrieval, rate limit handling, synchronization processing, URL status checks, data extraction, and merging/filtering of data.
Unit tests to verify the functionality of TransitFeedSyncProcessor, covering data retrieval, rate limit handling, synchronization processing, URL status checks, data extraction, and merging/filtering of data.
AlfredNwolisa
changed the title
AlfredNwolisa
requested review from
davidgamez and
cka-y
and removed request for
davidgamez
davidgamez
reviewed
Oct 16, 2024
Comment on lines
8
to
12
| { | ||
| "execution_id": "execution_id", | ||
| "feed_stable_id": "feed_stable_id", | ||
| "feed_id": "feed_id", | ||
| "feed_onestop_id": "feed_onestop_id" |
There was a problem hiding this comment.
If this function sends the TransitFeedSyncPayload as a payload, please add all fields in here
| # payloads for publishing to queue | ||
| payloads = [] | ||
| for data in combined_data: | ||
| associated_id = self.get_associated_id(db_session, data['feeds_onestop_id']) |
There was a problem hiding this comment.
We need to filter the associated ID by the ID and the source. This ensures that the ID doesn't conflict with any other source. You can use the transit land source as: "TLD".
Standardized comments and docstrings for better clarity and consistency. Improved code readability by cleaning up unnecessary lines and aligning comment styles.
Ensured that all modified files include a newline at the end
Updated README.md
…e readability and maintain consistency.
Added 'source' attribute to payload and implemented new logic for determining feed updates or new entries based on 'external_id' and 'source'. Refactored test cases to align with these changes.
Extended the timeout for the `requests.head` call from 10 to 25 seconds to accommodate slower server responses.
Added 'source' parameter in README.md and reformat function arguments in main.py and test_feed_sync.py for better readability. Ensure consistent indentation and correct minor formatting issues.
Added 'source' parameter in README.md and reformat function arguments in main.py and test_feed_sync.py for better readability. Ensure consistent indentation and correct minor formatting issues.
Added the 'source' field to the payload dictionary in the README.md example and made minor whitespace adjustments in the main source and test files.
5 tasks
davidgamez
reviewed
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Summarize the changes in the pull request including how it relates to any issues (include the #number, or link them).
Expected behavior:
Explain and/or show screenshots for how you expect the pull request to work in your testing (in case other devices exhibit different behavior).
Testing tips:
Provide tips, procedures and sample files on how to test the feature.
Testers are invited to follow the tips AND to try anything they deem relevant outside the bounds of the testing tips.
Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.shto make sure you didn't break anything