Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mislabeling of feeds from Turkey, Kocaeli, Izmit to Turkey, Izmir #496

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

yasinkaraaslan
Copy link
Contributor

@yasinkaraaslan yasinkaraaslan commented Aug 27, 2024

fix: Fixed incorrect locations of feeds that were previously mislabeled as Turkey, Kocaeli, Izmit. The feeds are actually for Turkey, Izmir. (Also fixing this pr)

  • tr-kocaeli-metro-izmir-gtfs-1824.json
  • tr-kocaeli-eshot-gtfs-1823.json
  • tr-kocaeli-izban-gtfs-1828.json
  • tr-kocaeli-tram-izmir-gtfs-1829.json

I am not sure if the files need to be renamed as well.

@CLAassistant
Copy link

CLAassistant commented Aug 27, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@emmambd emmambd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this great contribution @yasinkaraaslan! I really appreciate you correcting my mistake. As I mentioned in my email,

For mdb-1824: In cases where the data is invalid like this one, we use the manually input location as a fallback. We need to make some changes to the API to display the location update, which we'll do in the next month. You can follow our progress here.

@emmambd emmambd merged commit cd2cbe8 into MobilityData:main Aug 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants