Remove duplicate feed for Donkey Republic in Rotterdam #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes a duplicate feed from @DonkeyRepublic [systems.csv](https://github.com/MobilityData/gbfs/blob/master/systems.csv) for Rotterdam. Indeed, the feed for system id `donkey_rotterdam_den_haag` contains exactly the same information as the feed for system id `donkey_rt`, minus some information. The feed should be removed to avoid duplicates. Identical information in the following files: - station_information.json - station_status.json - system_hours.json - system_regions.json - gbfs_versions.json - vehicle_types.json Extra information in the following files of `donkey_rt`: - system_information (license_url, purchase_url, url) - system_pricing_plans.json (url) - free_bike_status (one extra bike) Thank you @merjakaj for raising this issue.
cka-y
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a duplicate feed from @DonkeyRepublic in systems.csv for Rotterdam.
Indeed, the feed for the system with id
donkey_rotterdam_den_haagcontains exactly the same information as the feed for the system with iddonkey_rt, minus some information. The first feed (with less information) should be removed to avoid duplicates.Identical information in the following files for
donkey_rtanddonkey_rotterdam_den_haag:Extra information in the following files of
donkey_rt:Thank you @merjakaj for raising this issue.