Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spec violation rules #141

Closed
wants to merge 24 commits into from
Closed

Add spec violation rules #141

wants to merge 24 commits into from

Commits on Oct 24, 2023

  1. Custom validations 

    Signed-off-by: Tom <[email protected]>
    @tdelmas @davidgamez
    tdelmas authored and davidgamez committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    92c46af View commit details
    Browse the repository at this point in the history

  2. Better display & error counts 

    Signed-off-by: Tom <[email protected]>
    @tdelmas @davidgamez
    tdelmas authored and davidgamez committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    50dfba6 View commit details
    Browse the repository at this point in the history

  3. Regroup all errors on front 

    Signed-off-by: Pierrick <[email protected]>
    @PierrickP @davidgamez
    PierrickP authored and davidgamez committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    12c640a View commit details
    Browse the repository at this point in the history

  4. Rename otherValidation to nonSchemaValidation 

    Signed-off-by: Pierrick <[email protected]>
    @PierrickP @davidgamez
    PierrickP authored and davidgamez committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    9cc5938 View commit details
    Browse the repository at this point in the history

  5. Add duplicate_vehicle_type_id error 

    Signed-off-by: Pierrick <[email protected]>
    @PierrickP @davidgamez
    PierrickP authored and davidgamez committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    2170404 View commit details
    Browse the repository at this point in the history

  6. Fix typos 

    Signed-off-by: Tom <[email protected]>
    @tdelmas @davidgamez
    tdelmas authored and davidgamez committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    f9dfc5a View commit details
    Browse the repository at this point in the history

  7. Fix when errors is false but not nonSchemaErrors 

    Signed-off-by: Tom <[email protected]>
    @tdelmas @davidgamez
    tdelmas authored and davidgamez committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    deae327 View commit details
    Browse the repository at this point in the history

  8. Most review suggestions 

    Signed-off-by: Tom <[email protected]>
    @tdelmas @davidgamez
    tdelmas authored and davidgamez committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    bb49a1c View commit details
    Browse the repository at this point in the history

  9. Removes the rules that are not in the spec

    @richfab
    richfab committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    1435e7f View commit details
    Browse the repository at this point in the history

  10. Collapse errors and warnings

    @richfab
    richfab committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    bad9010 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Provide the actual value of last_updated

    @richfab
    richfab committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    598e14f View commit details
    Browse the repository at this point in the history

  2. Fix typo in exhaustive

    @richfab
    richfab committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    352b25b View commit details
    Browse the repository at this point in the history

  3. Improve test message

    @richfab
    richfab committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    00028ff View commit details
    Browse the repository at this point in the history

  4. Return the result of hasErrors and hasWarnings

    @richfab
    richfab committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    a3e498e View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Specify from which version the rules apply

    @richfab
    richfab committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    86cd938 View commit details
    Browse the repository at this point in the history

  2. Use forEach in loops instead of map

    @richfab
    richfab committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    8f4ba14 View commit details
    Browse the repository at this point in the history

  3. Fix line starting with semicolon

    @richfab
    richfab committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    3054d26 View commit details
    Browse the repository at this point in the history

  4. Use Array#some

    @richfab
    richfab committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    7013a67 View commit details
    Browse the repository at this point in the history

  5. Take metadata out of error message for consistency

    @richfab
    richfab committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    1e0569d View commit details
    Browse the repository at this point in the history

  6. Typo in multipolygon

    @richfab
    richfab committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    e747ccb View commit details
    Browse the repository at this point in the history

  7. Variable name for coordinates of a multipolygon

    @richfab
    richfab committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    1844e72 View commit details
    Browse the repository at this point in the history

  8. Variable name polygonCoordinates

    @richfab
    richfab committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    cf2bfae View commit details
    Browse the repository at this point in the history

  9. Rename variable o to rules

    @richfab
    richfab committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    b4a2832 View commit details
    Browse the repository at this point in the history

  10. Undo Use Array#some because the tests failed

    @richfab
    richfab committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    d271ba8 View commit details
    Browse the repository at this point in the history