Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configs for simple models #178

Conversation

mikesokolovv
Copy link
Collaborator

@mikesokolovv mikesokolovv commented Aug 13, 2024

Description

  • Added model configs for EASE, Random and PureSVD models
  • Moved RandomState serialization to models/base.py

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Optimization

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3246ce7) to head (f6840d8).

Additional details and impacted files
@@                   Coverage Diff                   @@
##           feature/model_configs      #178   +/-   ##
=======================================================
  Coverage                 100.00%   100.00%           
=======================================================
  Files                         56        56           
  Lines                       3519      3555   +36     
=======================================================
+ Hits                        3519      3555   +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@feldlime
Copy link
Collaborator

Hi, thanks for PR!
Could you please give it a more relevant name? "Additional" is quite ambiguous; for me, it sounds like "optional."
Also, please separate changes in the description into 2 bullet points (added configs and moved rs)

rectools/models/ease.py Outdated Show resolved Hide resolved
rectools/models/pure_svd.py Outdated Show resolved Hide resolved
rectools/models/random.py Outdated Show resolved Hide resolved
tests/models/test_ease.py Outdated Show resolved Hide resolved
@mikesokolovv mikesokolovv changed the title Feature/additional model configs Feature/optional model configs Aug 13, 2024
@feldlime
Copy link
Collaborator

Could you please give it a more relevant name? "Additional" is quite ambiguous; for me, it sounds like "optional."

By this I wanted to say that "additional" sounds like "optional", but these configs are not "optional" and hence not "additional". So, please, give to this PR some meaningful name, and better do not connect it with the branch name since it's already different. You can name it Configs for simple models, it'd be fine.
Sorry for confusion.

@mikesokolovv mikesokolovv changed the title Feature/optional model configs Configs for simple models Aug 14, 2024
tests/models/utils.py Outdated Show resolved Hide resolved
@feldlime feldlime merged commit 268268b into MobileTeleSystems:feature/model_configs Aug 14, 2024
9 checks passed
mikesokolovv added a commit to mikesokolovv/RecTools that referenced this pull request Sep 4, 2024
- Added model configs for `EASE`, `Random` and `PureSVD` models
- Moved `RandomState` serialization to models/base.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants