Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in MetricsApp's display() method #169

Merged
merged 12 commits into from
Aug 12, 2024

Conversation

Gooogr
Copy link
Contributor

@Gooogr Gooogr commented Jul 30, 2024

Description

  • Fix code error local variable fig_widget referenced before assignment after calling display() method of MetricsApp instance.
  • Fix nbformat error after extracting plotly figure from chart. Add nbformat to project dependencies

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Optimization

How Has This Been Tested?

Before submitting a PR, please check yourself against the following list. It would save us quite a lot of time.

  • Have you read the contribution guide?
  • Have you updated the relevant docstrings? We're using Numpy format, please double-check yourself
  • Does your change require any new tests?
  • Have you updated the changelog file?

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9b3992e) to head (01a4e48).
Report is 61 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #169     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           45        56     +11     
  Lines         2242      3446   +1204     
===========================================
+ Hits          2242      3446   +1204     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rectools/visuals/metrics_app.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
rectools/visuals/metrics_app.py Outdated Show resolved Hide resolved
poetry.lock Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@blondered blondered merged commit 0f4034c into MobileTeleSystems:main Aug 12, 2024
9 checks passed
blondered pushed a commit that referenced this pull request Sep 23, 2024
- Fixed `MetricsApp` `display` method
- Added `nbformat` to dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants