fixed test with unsupported targets

tests/models/test_base.py

@@ -342,20 +342,26 @@ def test_full_model_works_for_all_without_features(self, kind: str) -> None:
     @pytest.mark.parametrize("dataset_key", ("no_features", "with_features"))
     @pytest.mark.parametrize("kind", ("u2i", "i2i"))
     @pytest.mark.parametrize("model_key", ("hot", "hot_warm"))
-    def test_not_cold_models_with_cold_targets(self, dataset_key: str, kind: str, model_key: str) -> None:
+    def test_not_cold_models_with_cold_targets_raise(self, dataset_key: str, kind: str, model_key: str) -> None:
         targets = self.colds[kind] + self.hots[kind]
-
-        # raise
         with pytest.raises(ValueError, match="doesn't support recommendations for cold"):
             self._get_reco(targets, model_key, dataset_key, kind, on_unsupported_targets="raise")
 
-        # ignore
+    @pytest.mark.parametrize("dataset_key", ("no_features", "with_features"))
+    @pytest.mark.parametrize("kind", ("u2i", "i2i"))
+    @pytest.mark.parametrize("model_key", ("hot", "hot_warm"))
+    def test_not_cold_models_with_cold_targets_ignore(self, dataset_key: str, kind: str, model_key: str) -> None:
+        targets = self.colds[kind] + self.hots[kind]
         actual = self._get_reco(targets, model_key, dataset_key, kind, on_unsupported_targets="ignore")
         expected_targets = self.hots[kind]
         expected = self._get_reco(expected_targets, model_key, dataset_key, kind)
         pd.testing.assert_frame_equal(actual, expected)
 
-        # warn
+    @pytest.mark.parametrize("dataset_key", ("no_features", "with_features"))
+    @pytest.mark.parametrize("kind", ("u2i", "i2i"))
+    @pytest.mark.parametrize("model_key", ("hot", "hot_warm"))
+    def test_not_cold_models_with_cold_targets_warn(self, dataset_key: str, kind: str, model_key: str) -> None:
+        targets = self.colds[kind] + self.hots[kind]
         with warnings.catch_warnings(record=True) as w:
             self._get_reco(targets, model_key, dataset_key, kind, on_unsupported_targets="warn")
             assert len(w) == 1
@@ -364,20 +370,24 @@ def test_not_cold_models_with_cold_targets(self, dataset_key: str, kind: str, mo
             assert "warm" not in str(w[-1].message)
 
     @pytest.mark.parametrize("kind", ("u2i", "i2i"))
-    def test_warm_only_model_with_warm_targets_without_features(self, kind: str) -> None:
+    def test_warm_only_model_with_warm_targets_without_features_raise(self, kind: str) -> None:
         targets = self.warms[kind] + self.hots[kind]
-
-        # raise
         with pytest.raises(ValueError, match="doesn't support recommendations for cold"):
             self._get_reco(targets, "hot_warm", "no_features", kind, on_unsupported_targets="raise")
 
+    @pytest.mark.parametrize("kind", ("u2i", "i2i"))
+    def test_warm_only_model_with_warm_targets_without_features_ignore(self, kind: str) -> None:
+        targets = self.warms[kind] + self.hots[kind]
+
         # ignore
         actual = self._get_reco(targets, "hot_warm", "no_features", kind, on_unsupported_targets="ignore")
         expected_targets = self.hots[kind]
         expected = self._get_reco(expected_targets, "hot_warm", "no_features", kind)
         pd.testing.assert_frame_equal(actual, expected)
 
-        # warn
+    @pytest.mark.parametrize("kind", ("u2i", "i2i"))
+    def test_warm_only_model_with_warm_targets_without_features_warn(self, kind: str) -> None:
+        targets = self.warms[kind] + self.hots[kind]
         with warnings.catch_warnings(record=True) as w:
             self._get_reco(targets, "hot_warm", "no_features", kind, on_unsupported_targets="warn")
             assert len(w) == 1
@@ -386,20 +396,22 @@ def test_warm_only_model_with_warm_targets_without_features(self, kind: str) ->
             assert "warm" not in str(w[-1].message)
 
     @pytest.mark.parametrize("kind", ("u2i", "i2i"))
-    def test_hot_only_model_with_warm_targets(self, kind: str) -> None:
+    def test_hot_only_model_with_warm_targets_raise(self, kind: str) -> None:
         targets = self.warms[kind] + self.hots[kind]
-
-        # raise
         with pytest.raises(ValueError, match="doesn't support recommendations for warm"):
             self._get_reco(targets, "hot", "with_features", kind, on_unsupported_targets="raise")
 
-        # ignore
+    @pytest.mark.parametrize("kind", ("u2i", "i2i"))
+    def test_hot_only_model_with_warm_targets_ignore(self, kind: str) -> None:
+        targets = self.warms[kind] + self.hots[kind]
         actual = self._get_reco(targets, "hot", "with_features", kind, on_unsupported_targets="ignore")
         expected_targets = self.hots[kind]
         expected = self._get_reco(expected_targets, "hot", "with_features", kind)
         pd.testing.assert_frame_equal(actual, expected)
 
-        # warn
+    @pytest.mark.parametrize("kind", ("u2i", "i2i"))
+    def test_hot_only_model_with_warm_targets_warn(self, kind: str) -> None:
+        targets = self.warms[kind] + self.hots[kind]
         with warnings.catch_warnings(record=True) as w:
             self._get_reco(targets, "hot", "with_features", kind, on_unsupported_targets="warn")
             assert len(w) == 1