Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daily message limit per user #2417

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shatfield4
Copy link
Collaborator

Pull Request Type

  • ✨ feat
  • πŸ› fix
  • ♻️ refactor
  • πŸ’„ style
  • πŸ”¨ chore
  • πŸ“ docs

Relevant Issues

resolves #2415

What is in this change?

  • Fix typos in username validation text
  • Remove old functionality of restricting daily message limit for all users except admins
  • Implement restricting daily message limit for users
  • Remove unused endpoints
  • Remove general settings page since no longer needed (only setting on this page was restricting daily message limit for all users)

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

Comment on lines +36 to +38
dailyMessageLimit: (dailyMessageLimit = null) => {
return dailyMessageLimit === null ? null : Number(dailyMessageLimit);
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be >= 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT]: Be able to set daily conversations per user instead of global setting
2 participants