Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.18.x] Configurable Configurations #426

Merged
merged 5 commits into from
Apr 8, 2022

Conversation

ChampionAsh5357
Copy link
Contributor

@ChampionAsh5357 ChampionAsh5357 commented Mar 29, 2022

Adds documentation for mod configurations. Anything that has been heavily documented by Forge or directly part of night-config has been delegated to their own library or documentation.

Supersedes and closes #303.

@ChampionAsh5357 ChampionAsh5357 added New Page Adds a new page 1.18 For Minecraft 1.18.x labels Mar 29, 2022
Copy link
Contributor

@sciwhiz12 sciwhiz12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a part in the docs (whether as a paragraph/admonition in the lead section or as a new section) which explains when it is appropriate to expose configurable settings as mod configuration files vs data files (in a datapack).

docs/misc/config.md Outdated Show resolved Hide resolved
docs/misc/config.md Outdated Show resolved Hide resolved
docs/misc/config.md Outdated Show resolved Hide resolved
docs/misc/config.md Outdated Show resolved Hide resolved
docs/misc/config.md Outdated Show resolved Hide resolved
docs/misc/config.md Outdated Show resolved Hide resolved
docs/misc/config.md Outdated Show resolved Hide resolved
docs/misc/config.md Outdated Show resolved Hide resolved
docs/misc/config.md Outdated Show resolved Hide resolved
docs/misc/config.md Outdated Show resolved Hide resolved
docs/misc/config.md Outdated Show resolved Hide resolved
docs/misc/config.md Outdated Show resolved Hide resolved
docs/misc/config.md Outdated Show resolved Hide resolved
docs/misc/config.md Show resolved Hide resolved
docs/misc/config.md Outdated Show resolved Hide resolved
docs/misc/config.md Outdated Show resolved Hide resolved
docs/misc/config.md Outdated Show resolved Hide resolved
docs/misc/config.md Outdated Show resolved Hide resolved
docs/misc/config.md Outdated Show resolved Hide resolved
@sciwhiz12 sciwhiz12 merged commit 2164237 into MinecraftForge:1.18.x Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.18 For Minecraft 1.18.x New Page Adds a new page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants