Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented feature from Issue #9 #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CptZee
Copy link

@CptZee CptZee commented May 27, 2024

Added the following for the eng.yml

Line 154

IslandInfoLoading: §aLoading your island's information...
#Supports '&' Chat colors
IslandInfoLabelAge: '&e&lIsland Age&7: &a'
IslandInfoLabelSize: '&e&lIsland Size&7: &a'
IslandInfoLabelSizeUnits: '&ablocks'
IslandInfoLabelDifficulty: '&e&lIsland Difficulty&7: &a'
IslandInfoLabelTotalMembers: '&e&lIsland Total Members&7: &a'
IslandInfoLabelZBorder: '&e&lIsland Z Border&7: &a'
IslandInfoLabelXBorder: '&e&lIsland X Border&7: &a'
IslandInfoLabelLevel: '&e&lIsland Level&7: &a'
IslandInfoLabelProgress: '&e&lLevel Progress&7: &a'
IslandInfoLabelChallenges: '&e&lChallenges Completed&7: &a'

Sample usage:
image


IssueHunt Summary

Referenced issues

This pull request has been submitted to:


Copy link
Member

@Phoenix616 Phoenix616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First let me say thank you for your PR! I'm sorry for only responding to this now, this somehow slipped through.

I'm not sure if I'm a bit fan of the way this is implemented. Especially the creation timestamp while nice would cause some headaches: It will break for existing islands and the timestamp messages aren't translatable either (my server is German so would want to offer them in German too) Maybe just remove the timestamp stuff for now, I don't think I would need that.

Also I would kinda prefer placeholders to be used in the info messages so that I can position them myself. Maybe just have one IslandInfo multiline string which just uses placeholders for all values so one can position and format the output however one wants (and change the order) without being limited by the hardcoded order and displayed values?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants