-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GitHub EMU GHE.com tutorial to point to the correct app #1200
base: main
Are you sure you want to change the base?
Conversation
Learn Build status updates of commit fcdf905:
|
File | Status | Preview URL | Details |
---|---|---|---|
docs/identity/saas-apps/github-enterprise-managed-user-ghe-com-tutorial.md | Details |
docs/identity/saas-apps/github-enterprise-managed-user-ghe-com-tutorial.md
- Line 58, Column 6: [Warning: bookmark-not-found - See documentation]
Cannot find bookmark '#configure-github-enterprise-managed-user---ghecom-sso' in 'identity/saas-apps/github-enterprise-managed-user-ghe-com-tutorial.md'.
- Line 59, Column 10: [Warning: bookmark-not-found - See documentation]
Cannot find bookmark '#create-github-enterprise-managed-user---ghecom-test-user' in 'identity/saas-apps/github-enterprise-managed-user-ghe-com-tutorial.md'.
- Line 3, Column 14: [Suggestion: duplicate-descriptions - See documentation]
Attribute 'description' with value 'Learn how to configure single sign-on between Microsoft Entra ID and GitHub Enterprise Managed User.' is duplicated in 'identity/saas-apps/github-enterprise-managed-user-ghe-com-tutorial.md(3,14)', 'identity/saas-apps/github-enterprise-managed-user-tutorial.md(3,14)'.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@isaacmbrown - we can move forward with this PR after you've agreed to the CLA. please follow the instructions here: #1200 (comment) @MicrosoftDocs/public-repo-pr-review-team |
@microsoft-github-policy-service agree company="GitHub" |
@isaacmbrown : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
Learn Build status updates of commit 06db1fa:
|
File | Status | Preview URL | Details |
---|---|---|---|
docs/identity/saas-apps/github-enterprise-managed-user-ghe-com-tutorial.md | Details | ||
docs/identity/saas-apps/github-enterprise-managed-user-provisioning-tutorial.md | ✅Succeeded |
docs/identity/saas-apps/github-enterprise-managed-user-ghe-com-tutorial.md
- Line 58, Column 6: [Warning: bookmark-not-found - See documentation]
Cannot find bookmark '#configure-github-enterprise-managed-user---ghecom-sso' in 'identity/saas-apps/github-enterprise-managed-user-ghe-com-tutorial.md'.
- Line 59, Column 10: [Warning: bookmark-not-found - See documentation]
Cannot find bookmark '#create-github-enterprise-managed-user---ghecom-test-user' in 'identity/saas-apps/github-enterprise-managed-user-ghe-com-tutorial.md'.
- Line 3, Column 14: [Suggestion: duplicate-descriptions - See documentation]
Attribute 'description' with value 'Learn how to configure single sign-on between Microsoft Entra ID and GitHub Enterprise Managed User.' is duplicated in 'identity/saas-apps/github-enterprise-managed-user-ghe-com-tutorial.md(3,14)', 'identity/saas-apps/github-enterprise-managed-user-tutorial.md(3,14)'.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
Learn Build status updates of commit 9fc3e50:
|
File | Status | Preview URL | Details |
---|---|---|---|
docs/identity/saas-apps/github-enterprise-managed-user-ghe-com-tutorial.md | Details | ||
docs/identity/saas-apps/github-enterprise-managed-user-oidc-provisioning-tutorial.md | ✅Succeeded | ||
docs/identity/saas-apps/github-enterprise-managed-user-provisioning-tutorial.md | ✅Succeeded |
docs/identity/saas-apps/github-enterprise-managed-user-ghe-com-tutorial.md
- Line 58, Column 6: [Warning: bookmark-not-found - See documentation]
Cannot find bookmark '#configure-github-enterprise-managed-user---ghecom-sso' in 'identity/saas-apps/github-enterprise-managed-user-ghe-com-tutorial.md'.
- Line 59, Column 10: [Warning: bookmark-not-found - See documentation]
Cannot find bookmark '#create-github-enterprise-managed-user---ghecom-test-user' in 'identity/saas-apps/github-enterprise-managed-user-ghe-com-tutorial.md'.
- Line 3, Column 14: [Suggestion: duplicate-descriptions - See documentation]
Attribute 'description' with value 'Learn how to configure single sign-on between Microsoft Entra ID and GitHub Enterprise Managed User.' is duplicated in 'identity/saas-apps/github-enterprise-managed-user-ghe-com-tutorial.md(3,14)', 'identity/saas-apps/github-enterprise-managed-user-tutorial.md(3,14)'.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
@jeevansd 👋 I updated this PR with some additional changes to the provisioning guides (for SAML and OIDC).
|
I am told that the app linked from this tutorial is not correct, and customers should use the standard GitHub EMU app for both GitHub.com and GHE.com.
It is useful to keep the guide because it includes the correct URL values for enterprises on GHE.com. I've updated references to the app name and copied the instructions for the installation section from https://github.com/MicrosoftDocs/entra-docs/blob/main/docs/identity/saas-apps/github-enterprise-managed-user-tutorial.md?plain=1.
NOTE: We need these updates merged before 29 October?