Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub EMU GHE.com tutorial to point to the correct app #1200

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

isaacmbrown
Copy link

@isaacmbrown isaacmbrown commented Oct 17, 2024

I am told that the app linked from this tutorial is not correct, and customers should use the standard GitHub EMU app for both GitHub.com and GHE.com.

It is useful to keep the guide because it includes the correct URL values for enterprises on GHE.com. I've updated references to the app name and copied the instructions for the installation section from https://github.com/MicrosoftDocs/entra-docs/blob/main/docs/identity/saas-apps/github-enterprise-managed-user-tutorial.md?plain=1.

NOTE: We need these updates merged before 29 October?

Copy link
Contributor

Learn Build status updates of commit fcdf905:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/identity/saas-apps/github-enterprise-managed-user-ghe-com-tutorial.md ⚠️Warning Details

docs/identity/saas-apps/github-enterprise-managed-user-ghe-com-tutorial.md

  • Line 58, Column 6: [Warning: bookmark-not-found - See documentation] Cannot find bookmark '#configure-github-enterprise-managed-user---ghecom-sso' in 'identity/saas-apps/github-enterprise-managed-user-ghe-com-tutorial.md'.
  • Line 59, Column 10: [Warning: bookmark-not-found - See documentation] Cannot find bookmark '#create-github-enterprise-managed-user---ghecom-test-user' in 'identity/saas-apps/github-enterprise-managed-user-ghe-com-tutorial.md'.
  • Line 3, Column 14: [Suggestion: duplicate-descriptions - See documentation] Attribute 'description' with value 'Learn how to configure single sign-on between Microsoft Entra ID and GitHub Enterprise Managed User.' is duplicated in 'identity/saas-apps/github-enterprise-managed-user-ghe-com-tutorial.md(3,14)', 'identity/saas-apps/github-enterprise-managed-user-tutorial.md(3,14)'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link

@wowyzga wowyzga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jak-MS
Copy link
Contributor

Jak-MS commented Oct 17, 2024

@isaacmbrown - we can move forward with this PR after you've agreed to the CLA. please follow the instructions here: #1200 (comment)

@MicrosoftDocs/public-repo-pr-review-team

@isaacmbrown
Copy link
Author

@microsoft-github-policy-service agree company="GitHub"

Copy link
Contributor

@isaacmbrown : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ShannonLeavitt
Copy link
Contributor

@jeevansd

Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Copy link
Contributor

Learn Build status updates of commit 06db1fa:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/identity/saas-apps/github-enterprise-managed-user-ghe-com-tutorial.md ⚠️Warning Details
docs/identity/saas-apps/github-enterprise-managed-user-provisioning-tutorial.md ✅Succeeded

docs/identity/saas-apps/github-enterprise-managed-user-ghe-com-tutorial.md

  • Line 58, Column 6: [Warning: bookmark-not-found - See documentation] Cannot find bookmark '#configure-github-enterprise-managed-user---ghecom-sso' in 'identity/saas-apps/github-enterprise-managed-user-ghe-com-tutorial.md'.
  • Line 59, Column 10: [Warning: bookmark-not-found - See documentation] Cannot find bookmark '#create-github-enterprise-managed-user---ghecom-test-user' in 'identity/saas-apps/github-enterprise-managed-user-ghe-com-tutorial.md'.
  • Line 3, Column 14: [Suggestion: duplicate-descriptions - See documentation] Attribute 'description' with value 'Learn how to configure single sign-on between Microsoft Entra ID and GitHub Enterprise Managed User.' is duplicated in 'identity/saas-apps/github-enterprise-managed-user-ghe-com-tutorial.md(3,14)', 'identity/saas-apps/github-enterprise-managed-user-tutorial.md(3,14)'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 9fc3e50:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/identity/saas-apps/github-enterprise-managed-user-ghe-com-tutorial.md ⚠️Warning Details
docs/identity/saas-apps/github-enterprise-managed-user-oidc-provisioning-tutorial.md ✅Succeeded
docs/identity/saas-apps/github-enterprise-managed-user-provisioning-tutorial.md ✅Succeeded

docs/identity/saas-apps/github-enterprise-managed-user-ghe-com-tutorial.md

  • Line 58, Column 6: [Warning: bookmark-not-found - See documentation] Cannot find bookmark '#configure-github-enterprise-managed-user---ghecom-sso' in 'identity/saas-apps/github-enterprise-managed-user-ghe-com-tutorial.md'.
  • Line 59, Column 10: [Warning: bookmark-not-found - See documentation] Cannot find bookmark '#create-github-enterprise-managed-user---ghecom-test-user' in 'identity/saas-apps/github-enterprise-managed-user-ghe-com-tutorial.md'.
  • Line 3, Column 14: [Suggestion: duplicate-descriptions - See documentation] Attribute 'description' with value 'Learn how to configure single sign-on between Microsoft Entra ID and GitHub Enterprise Managed User.' is duplicated in 'identity/saas-apps/github-enterprise-managed-user-ghe-com-tutorial.md(3,14)', 'identity/saas-apps/github-enterprise-managed-user-tutorial.md(3,14)'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@isaacmbrown
Copy link
Author

@jeevansd 👋 I updated this PR with some additional changes to the provisioning guides (for SAML and OIDC).

  • Added the correct tenant URL for GHE.com: it helps us to have this information in the Entra docs to avoid telling people to substitute values in the Entra guides we're linking.
  • Updated the sections about the access token: the required scope recently changed to scim:enterprise. I think it's easiest just to link to the docs on GitHub Docs for creating the token, in case of any future changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants