-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove MV2 code from "Create an extension tutorial, part 1" #3277
Open
bhuvanapriyap
wants to merge
47
commits into
main
Choose a base branch
from
user/bhuvanap/removemv2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikehoffms
changed the title
Update part1-simple-extension.md
Remove MV2 code from "Create an extension tutorial, part 1"
Sep 24, 2024
mikehoffms
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Writer/Editor
mikehoffms
reviewed
Sep 24, 2024
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension.md
Outdated
Show resolved
Hide resolved
mikehoffms
reviewed
Sep 24, 2024
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension.md
Outdated
Show resolved
Hide resolved
captainbrosset
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the content changes, but we need to update the samples repo to v3 at the same time.
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension.md
Outdated
Show resolved
Hide resolved
mikehoffms
added
the
on-hold
The changes are currently on-hold and awaiting further evaluation.
label
Sep 25, 2024
mikehoffms
reviewed
Sep 25, 2024
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension.md
Outdated
Show resolved
Hide resolved
mikehoffms
reviewed
Sep 25, 2024
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension.md
Show resolved
Hide resolved
mikehoffms
reviewed
Sep 25, 2024
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension.md
Outdated
Show resolved
Hide resolved
mikehoffms
reviewed
Sep 25, 2024
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension.md
Show resolved
Hide resolved
mikehoffms
reviewed
Sep 25, 2024
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension.md
Show resolved
Hide resolved
mikehoffms
reviewed
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cat: extensions
Extensions-related content.
on-hold
The changes are currently on-hold and awaiting further evaluation.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is finished & on-hold waiting for Extensions repo Part 1 to be updated from MV2 to MV3, per PR: microsoft/MicrosoftEdge-Extensions#202
manifest.json
:https://github.com/microsoft/MicrosoftEdge-Extensions/blob/main/Extension%20samples/extension-getting-started-part1/part1/manifest.json --
"manifest_version": 2,
When that line becomes
"manifest_version": 3,
, this PR can be merged.Rendered articles for review:
part1-simple-extension.md
)part2-content-scripts.md
)extension-sideloading.md
)~/index.yml
)/developer/index.yml
)/extensions/landing/index.yml
)toc.yml
)AB#54090321