Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement po_create()/po_update() for creating/updating translations #235
Implement po_create()/po_update() for creating/updating translations #235
Changes from all commits
3affcc0
63dcbc5
cfe1eff
b205c34
6124465
c644cb7
a088663
28f3e28
310f2b0
10e16fd
42885b1
205ee8f
0d3391d
d8880e0
efa92b6
511fad1
d7c3882
0daabcd
b604281
ef5449f
7322e55
78afb31
7133453
df99ea4
f081b01
6fd0c30
0e4371c
4b3353f
ae5c5b7
b4e71bd
b8e17e9
0f93068
3ff40d5
5efd88f
e6788bd
a36031a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it might be nice to
warn()
here if e.g. R-pkg.pot is present but pkg.pot is not & the package has asrc/
directory.OTOH, if the translation is handled entirely by
potools
, this should only happen ifsrc/
doesn't have any messages to translate, right? So maybe it will be a warning highly prone to false positives...skipping for now, but file a follow-up issue if you think the warning is worthwhile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the one place this will break is for
base
, which usesR-base.pot
for R andR.pot
for src. I'll just add a TODO for now to make sure that case is handled later.Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.