-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 1.18 issues #98
Open
0dinD
wants to merge
10
commits into
Mezy:master
Choose a base branch
from
0dinD:fix-1.18-issues
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix 1.18 issues #98
Commits on Jan 17, 2022
-
Configuration menu - View commit details
-
Copy full SHA for b0b2cce - Browse repository at this point
Copy the full SHA b0b2cceView commit details -
Update dependencies and repos to fix broken build
ProtocolLib 4.4.0 depends on a broken artifact (BukkitExecutors), which is now part of ProtocolLib itself as of version 4.6.0. See dmulloy2/ProtocolLib@7ac4ac6 AnvilGui needs to be shaded into the JAR.
Configuration menu - View commit details
-
Copy full SHA for 4ce8c4e - Browse repository at this point
Copy the full SHA 4ce8c4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a7237e - Browse repository at this point
Copy the full SHA 9a7237eView commit details -
MinecraftServer#setMotd was obfuscated in Spigot for 1.18, and maintaining an NMS solution using VersionUtils seems like more trouble than it's worth when we can just use PingListener to change the MOTD.
Configuration menu - View commit details
-
Copy full SHA for 78989c5 - Browse repository at this point
Copy the full SHA 78989c5View commit details
Commits on Mar 4, 2022
-
Avoid usage of BiomeMapping in 1.18+
Replacing ocean biomes no longer works with the new terrain generation system, so it's better to log a warning. This also avoids a plugin crash in 1.18.2, for which there is no BiomeMapping release yet (and it's unclear if there will ever be one).
Configuration menu - View commit details
-
Copy full SHA for c443367 - Browse repository at this point
Copy the full SHA c443367View commit details
Commits on Mar 9, 2022
-
Add VersionAdapter to support 'replace-ocean-biomes' on 1.18+
The benefit of VersionAdapter over VersionUtils is that each adapter implementation is built against its corresponding Paper/Spigot version, meaning it's easier to catch errors and less reflection has to be used. However, VersionUtils is tightly coupled with the rest of the codebase which makes it hard to migrate some methods without substantial refactoring. That'll be something to look at in the future.
Configuration menu - View commit details
-
Copy full SHA for 72c8fab - Browse repository at this point
Copy the full SHA 72c8fabView commit details -
This makes it easier to test the plugin on different server versions.
Configuration menu - View commit details
-
Copy full SHA for ecb104a - Browse repository at this point
Copy the full SHA ecb104aView commit details -
Improve Shadow plugin configuration
Previously it was applied to all projects, which is unnecessary and slows the build down. BiomeMapping is now shaded to avoid conflicts with other plugins.
Configuration menu - View commit details
-
Copy full SHA for 2f54917 - Browse repository at this point
Copy the full SHA 2f54917View commit details
Commits on Mar 10, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 1d71237 - Browse repository at this point
Copy the full SHA 1d71237View commit details
Commits on Mar 15, 2022
-
The issue was that task the configuration avoidance API has to be used explicitly in the Groovy DSL, see PaperMC/paperweight#143.
Configuration menu - View commit details
-
Copy full SHA for 110178a - Browse repository at this point
Copy the full SHA 110178aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.