Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Baritone Settings - Max values #4981

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

RuriYS
Copy link
Contributor

@RuriYS RuriYS commented Oct 25, 2024

Type of change

  • Bug fix (maybe)
  • New feature

Description

Some of Baritone's settings needs to have max values, or it will cause unexpected errors,
So I added maxValue for specific setting(s).

Affected settings:

  • pathCutoffFactor
  • might be even more...

Related issues

Mention any issues that this pr relates to.

How Has This Been Tested?

When pathing with Baritone, setting value of pathCutoffFactor above 1.0 would cause index out of bounds exceptions.

Checklist:

  • My code follows the style guidelines of this project.
  • I have added comments to my code in more complex areas.
  • I have tested the code in both development and production environments.

@RuriYS
Copy link
Contributor Author

RuriYS commented Oct 25, 2024

figured I don't need to touch DoubleSetting, mb

@Wide-Cat
Copy link
Collaborator

Currently this sets sliderMax, should we keep it as that or set the max value? I'm open to hearing thoughts either way. Also I don't think baritone caps this value either, might be worth opening a bug report on their repo if you haven't already.

@RuriYS
Copy link
Contributor Author

RuriYS commented Oct 25, 2024

Currently this sets sliderMax, should we keep it as that or set the max value?

Setting the max value is a great idea

Also I don't think baritone caps this value either, might be worth opening a bug report on their repo

I might, and unless my PR would be approved there then this is just a fix in meteor itself.

@Wide-Cat Wide-Cat merged commit c831138 into MeteorDevelopment:master Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants