Increase nametage scale when using Zoom #4979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm (let's get this merged)! |
|
Might be worth adding a config option in the future to set the text quality now. Maybe something to do in the future. |
|
Very nice. I'll try this out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
When using the Zoom module before, Nametags stayed at the same size and were unreadable when looking at players in the distance without explicitly increasing Nametage scale. This also includes a renaming of the
Zoom::valuefunction togetScalingand exposes it as a public method.Related issues
None (maybe #1394)
How Has This Been Tested?
Zoomed out:
Zoomed in:
Checklist: