Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
In 1.20.5 the c2s custom payload packet that contains the brand changed to a record.
Changing the internals is no longer possible because of that.
My previous fix changed the behavior of PacketEvent.Send and accidentally broke criticals
This new fix cancels the packet and while sending a new modified one.
The modified packet doesn't trigger PacketEvent.Send which would cause an infinite loop.
Related issues
#4597
How Has This Been Tested?
Joining singleplayer doesn't break and the brand is changed in multiplayer environments.
Confirmed by joining eu.loyisa.cn which prints the client brand on join.
Checklist: