fixed ServerSpoof

[19MisterX98]

Type of change

• Bug fix
• New feature

Description

In 1.20.5 the c2s custom payload packet that contains the brand changed to a record.
Changing the internals is no longer possible because of that.
My previous fix changed the behavior of PacketEvent.Send and accidentally broke criticals
This new fix cancels the packet and while sending a new modified one.
The modified packet doesn't trigger PacketEvent.Send which would cause an infinite loop.

Related issues

#4597

How Has This Been Tested?

Joining singleplayer doesn't break and the brand is changed in multiplayer environments.
Confirmed by joining eu.loyisa.cn which prints the client brand on join.

Checklist:

• My code follows the style guidelines of this project.
• I have added comments to my code in more complex areas.
• I have tested the code in both development and production environments.

[Wide-Cat]

Instead of grabbing the ClientConnection from the connection screen, it would probably be better to post it with the event, as happens with PacketEvent.Recieve.

meteor-client/src/main/java/meteordevelopment/meteorclient/events/packets/PacketEvent.java

Line 17 in fa00a6d

public ClientConnection connection;

meteor-client/src/main/java/meteordevelopment/meteorclient/mixin/ClientConnectionMixin.java

Line 53 in fa00a6d

} else if (MeteorClient.EVENT_BUS.post(PacketEvent.Receive.get(packet, (ClientConnection) (Object) this)).isCancelled()) ci.cancel();