Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a method to zoom the video capture device using an optional rate #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dsmurfin
Copy link
Collaborator

@dsmurfin dsmurfin commented Mar 6, 2022

This is only available on iOS

@YuAo
Copy link
Member

YuAo commented Mar 8, 2022

  • Can you make this a separate extension like Camera+FocusExposure.swift.
  • It's better to just ignore the call when no video device is attached to match the current behavior of related setFocusExposurePointOfInterest, setExposureTargetBias methods, though I think throwing may be a good idea however let's just match the behavior for now.
  • How about clamping the zoomFactor to the supported range?

@dsmurfin
Copy link
Collaborator Author

dsmurfin commented Mar 8, 2022

This makes much more sense, I'll implement that way.

Clamping is very sensible. At the moment I'm doing this on my side before calling into VideoIO, but we should do this here.

@dsmurfin
Copy link
Collaborator Author

dsmurfin commented Apr 6, 2024

@YuAo this PR represents changes as discussed previously. The failing tests are all testPlayerVideoOutput_iOS which does not test any of the code impacted by this PR, and which I believe may need a longer timeout due to some environmental changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants