Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typecheck the result of term unquotation. #1098

Merged
merged 1 commit into from
Aug 30, 2024

Commits on Aug 30, 2024

  1. Typecheck the result of term unquotation.

    In some cases, unquoting could generate terms that were ill-typed, typically
    when unquoting [I @hole] for some template polymorphic inductive type [I].
    Similarly universe levels were not computed at all, which could have led
    to bizarre failures.
    
    To ensure that the unquoted term makes sense at all, we simply perform a
    call to Typing before returning it. This has a non-trivial cost but since
    building the term is already linear, this should not hopefully matter that
    much in practice.
    ppedrot committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    7bfa901 View commit details
    Browse the repository at this point in the history